-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
DOC: Remove old versions from doc dropdown #56999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Remove old versions from doc dropdown #56999
Conversation
|
I made a small edit to the 1.4.4 files on the server, and the 404 error should be fixed now. Personally, given that we are keeping those files on the server anyway, I would also keep them in the dropdown. Seems like low effort to keep them. For example for 1.5, if you look at download statistics from PyPI, 1.5 is still "used" (downloaded) almost as much as 2.0, and those two are half of 2.1. (will ask about adding an additional account for plausible) |
|
Thanks for the fix to 1.4, that's nice. To be clear, 1.5 is still kept in this PR (it's the last of the 1 series, so I'd leave it for long). I'd personally still move forward with this PR, as you say, to reduce noise and make it easier to find the relevant versions. If there is significant interest in these older versions (1.3 and 1.4 in particular) after merging this, I'm surely happy to add them back. But I think leaving from 1.5 onwards is what almost any user would need. Of course just my opinion, and if people think that people are actually using the dropdown for 1.0 to 1.4 I'm happy to close this and leave things as they are for now. |
mroeschke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed to remove these older version. IMO it helps indirectly encourage users to use more recent versions of pandas.
|
Again going on download stats (with all its disclaimers and limitations), pandas 1.3 is actually downloaded more than 1.4, 1.5, or 2.0.
I have no idea how many people use this (and the site analytics don't track that AFAIK ;), there are entry/exit pages, but I am not sure you can see that per individual page), but even if it's a small group of people using it, I think it's worth keeping it for them since it doesn't cost us much. Anyway, I don't see the value in removing them already now. But I also won't keep discussing, it's small enough of an issue to not be worth spending too much time on. |
|
The 1.3 version results seems consistent with analytics, it's interesting that many users stayed there. Closing here, we can revisit in the future. |
One more ;) I quickly took a look at our google analytics dashboard, and as I mentioned I not sure you can derive any information about this exactly (people using the dropdown), but just to have an idea how many of the page views are for specific versions: querying the pages on having "pandas-docs/version", and downloading the results of that for the last 28 days: So that are a bit more than 100k page views in total (which is a lot in absolute numbers, but luckily also only around 2% of all page views). Now, I assume that most of those page views are people getting there from clicking a link or from a search giving an old page |
My guess is that there is somewhere a package that has an (potentially unnecessary) pin on that pandas version. I would also be surprised if that many users actually did that intentionally. |
The version switcher in the docs is currently missing for <= v1.3 and broken for 1.4. I had a look at the views for the older versions, and I don't think it's worth to keep the old versions in the dropdown:
Note that this only affects the dropdown for the documentation of pandas 1.5+. The documentation of the old versions will continue to exist, and accessible from links on the internet, bookmarks or typing the url. And the dropdown in these old versions will continue to be broken. But from the main documentation it won't the possible to select 1.4 in the dropdown, and then get an error when trying to go back to the stable documentation.
The data in the screenshot is from Google analytics, from the first half of last year. @jorisvandenbossche can you add the url and credentials of Plausible to our credentials, so anyone can access the latest stats?
CC: @lithomas1