Skip to content

Conversation

@iridiium
Copy link

@iridiium iridiium commented Mar 7, 2024

@rhshadrach
Copy link
Member

Thanks for the PR @iridiium - looks like docstring validation is failing here and needs fixed.

@iridiium
Copy link
Author

I am aware of and currently fixing the issues, sorry for requesting reviews when unneeded.

@datapythonista datapythonista added Docs IO Excel read_excel, to_excel labels Mar 14, 2024
@datapythonista
Copy link
Member

@iridiium we changed how we specify the pending errors in code_checks.sh and you'll have to resolve the conflicts now, sorry about it.

@dontgoto
Copy link
Contributor

@iridiium if you want I can help with the updating of the error exceptions in the shell script. Just let me know

@iridiium
Copy link
Author

iridiium commented Mar 25, 2024

@iridiium if you want I can help with the updating of the error exceptions in the shell script. Just let me know

Sorry, I've been a bit busy lately, although I will try and work on this soon. I haven't been following the changes much and am not too sure on how to update this, how would I do so?

I haven't changed much, so I'd rather start fresh

@iridiium iridiium closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs IO Excel read_excel, to_excel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants