Skip to content

Conversation

@SoulofAkuma
Copy link
Contributor

@SoulofAkuma SoulofAkuma commented Oct 19, 2025

@SoulofAkuma SoulofAkuma changed the title Adjusted import and error message behavior based on types Raise on SQLAlchemy minimal version violation Issue #57178 Oct 19, 2025
@Alvaro-Kothe
Copy link
Member

as I cannot run them locally due to the required db setup.

You can use this docker-compose file and setup the databases with docker compose up

services:
  mysql:
    image: mysql:9
    environment:
      MYSQL_ALLOW_EMPTY_PASSWORD: yes
      MYSQL_DATABASE: pandas
    ports:
      - 3306:3306

  postgres:
    image: postgres:17
    environment:
      PGUSER: postgres
      POSTGRES_USER: postgres
      POSTGRES_PASSWORD: postgres
      POSTGRES_DB: pandas
    ports:
      - 5432:5432

@SoulofAkuma
Copy link
Contributor Author

as I cannot run them locally due to the required db setup.

You can use this docker-compose file and setup the databases with docker compose up

services:
  mysql:
    image: mysql:9
    environment:
      MYSQL_ALLOW_EMPTY_PASSWORD: yes
      MYSQL_DATABASE: pandas
    ports:
      - 3306:3306

  postgres:
    image: postgres:17
    environment:
      PGUSER: postgres
      POSTGRES_USER: postgres
      POSTGRES_PASSWORD: postgres
      POSTGRES_DB: pandas
    ports:
      - 5432:5432

Thanks, this is very useful. After review with @mroeschke , I will change the approach to this, which will just boil down to modifying the existing error message.

@SoulofAkuma
Copy link
Contributor Author

If this requires an entry in an rst file let me know. Not sure what version of the rst file that would be

@mroeschke mroeschke added this to the 3.0 milestone Oct 22, 2025
@mroeschke mroeschke added the Error Reporting Incorrect or improved errors from pandas label Oct 22, 2025
@mroeschke mroeschke merged commit 81f8d5d into pandas-dev:main Oct 22, 2025
46 of 47 checks passed
@mroeschke
Copy link
Member

Thanks @SoulofAkuma (no whatsnew entry needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Error Reporting Incorrect or improved errors from pandas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: Not silently ignore violation of minimal required version of SQLAlchemy

3 participants