CLN: create overflow verification functions in portable.h
#62765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alvaro-Kothe
force-pushed
the
refactor/overflow-checks
branch
from
e8c7f35 to
ff49b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor that moves overflow verification functions from
pandas/_libs/src/vendored/numpy/datetime/np_datetime.ctopandas/_libs/include/pandas/portable.h, and uses Generics to handle multiple integer types on Windows.This was originally from #62741, but this change a little bit unrelated to the fix, but I need the functions from this refactor to perform the overflow verifications.