CLN: Consolidate decimal string parsing functions in tokenizer.c #62823
+139
−152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Description
This PR consolidates two similar string manipulation functions in
tokenizer.c:_str_copy_decimal_str_c: handled decimal/thousands separator replacement with heap allocationcopy_string_without_char: removed characters with caller-provided bufferThe refactored
_str_copy_decimal_str_cnow combines the strengths of both approaches:strspn,memcpy) instead of byte-by-byte processingChanges
_str_copy_decimal_str_cto write to caller-provided buffer instead of heap allocationstr_consume_span, etc.) for efficient string parsingcopy_string_without_charfunctionstr_to_int64andstr_to_uint64to use the refactored functionround_tripfunction with stack buffer allocation