Skip to content

TYP: stronger typing for unit, as_unit #63162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2025
Merged

TYP: stronger typing for unit, as_unit #63162

merged 2 commits into from
Nov 25, 2025
+52 −19

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 20, 2025

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
  • If I used AI to develop this pull request, I prompted it to follow AGENTS.md.

@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Nov 25, 2025
@mroeschke mroeschke added this to the 3.0 milestone Nov 25, 2025
@mroeschke mroeschke merged commit d78d534 into pandas-dev:main Nov 25, 2025
75 of 79 checks passed
@mroeschke
Copy link
Member

mroeschke commented Nov 25, 2025

Thanks @jbrockmendel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @mroeschke