BUG: fixing toctree of single-page case #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
force-pushed
the
fix_notoctree
branch
from
e53c29f to
b934a16
Compare
|
rebased this one so that it can be merged. ping @jorisvandenbossche , I don't think this will be a controversial fix... |
jorisvandenbossche
changed the title
jorisvandenbossche
changed the title
jorisvandenbossche
approved these changes
Mar 20, 2020
|
We should probably start adding tests for some of those things (but I don't really look forward to testing sphinx apps .. I suppose sphinx has some machinery for testing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no
toctreedefined in the site (ie, if it is a single-page site) then theTocTreefunction returnsNoneand this breaks when we try to access.children. This PR accounts for this case.