Skip to content

Conversation

jorisvandenbossche
Copy link
Member

Closes #107

@jorisvandenbossche jorisvandenbossche changed the title Blacken codebase + add pre-commit hook Blacken codebase + add pre-commit hook + lint in CI Apr 19, 2020
@jorisvandenbossche
Copy link
Member Author

I added black and flake8 to the pre-commit hook, and now also a github action reuses this pre-commit hook as check on CI.

@choldgraf
Copy link
Collaborator

I'll give it until tomorrow morning for somebody to suggest otherwise, then I'll merge. I think it's a good idea to merge sooner than later, since if we don't merge relatively quickly we're going to hit merge conflicts each time the codebase changes.

@jorisvandenbossche jorisvandenbossche merged commit 90550b6 into pydata:master Apr 20, 2020
@jorisvandenbossche jorisvandenbossche deleted the blacken branch April 20, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a pre-commit hook for black

2 participants