Skip to content

Conversation

jorisvandenbossche
Copy link
Member

cc @hoetmaaiers I added a larger image to the demo site. But this mostly already seems to work OK (similar to bootstrap's img-fluid), since sphinx includes a max-width: 100% for img

@choldgraf choldgraf merged commit 8ae0c51 into pydata:master May 6, 2020
@jorisvandenbossche jorisvandenbossche deleted the demo-image branch May 6, 2020 06:15
@hoetmaaiers
Copy link
Collaborator

hoetmaaiers commented May 6, 2020

Ok, then I guess the max-width of 100% solves the scrolling question unless we intent to remove the max-width: 100% rule?

@jorisvandenbossche
Copy link
Member Author

For figures at least, yes (other things like tables still have scrolling issues). You are not a fan of using max-width: 100% for figures (as the default)?

@hoetmaaiers
Copy link
Collaborator

I do like max-width 100%, for enlarging it, a Lightbox-like solution would have my preference (if ever needed of course).

The scrolling issue for tables should be fixed in #174

@choldgraf choldgraf mentioned this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants