Using key navigation from sphinx instead of custom javascript #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
force-pushed
the
sphinx_nav_w_keys
branch
from
2050b56 to
f1c6802
Compare
jorisvandenbossche
changed the title
|
This is still GTG from my perspective 👍 |
|
Shall I close this? It seems not very high priority and I don't wanna keep these PRs dangling indefinitely |
|
If you have time to fix the merge conflict, it can certainly be added (I actually just forgot to merge it after fixing merge conflicts the last time ...) |
choldgraf
force-pushed
the
sphinx_nav_w_keys
branch
from
3f2be9f to
20dfb45
Compare
|
OK I think this should now be working, wanna double-check @jorisvandenbossche ? |
|
Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to give it a whirl myself and it was surprisingly easy!
This removes our custom button-pressing code, and replaces it with Sphinx's native page-flipping option