pangea-node-sdk: support AuthN usernames (GEA-14495) #1118
Conversation
kenany
force-pushed
the
kenany/GEA-14495/authn-usernames
branch
from
f8bf177 to
07f08c0
Compare
pangea-andrest
left a comment
pangea-andrest
left a comment
There was a problem hiding this comment.
Some comments to discuss. If they are okey, feel free to merge
| request: | ||
| | AuthN.User.Authenticators.Delete.EmailRequest | ||
| | AuthN.User.Authenticators.Delete.IDRequest | ||
| request: AuthN.User.Authenticators.Delete.Request |
There was a problem hiding this comment.
Ins't this a breaking change? Does AuthN.User.Authenticators.Delete.Request include the older classes?
There was a problem hiding this comment.
It's equivalent as far as this parameter is concerned, I've just consolidated what would have been 3 interfaces into 1 interface + 1 type.
There was a problem hiding this comment.
Got it, but my question is... if someone has something like
request: AuthN.User.Authenticators.Delete.EmailRequest = {
email: "foo@bar",
}
Will this still work or it will complain because it now takes a
request: AuthN.User.Authenticators.Delete.Request
There was a problem hiding this comment.
I don't think we document directly referencing the interfaces like that but since they are indeed public, sure, I have restored them all.
| login_count: number; | ||
| last_login_ip?: string; | ||
| last_login_city?: string; | ||
| last_login_country?: string; |
There was a problem hiding this comment.
Aren't these documented?
No description provided.