Create new Pangea token type #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept Pangea token type in service constructors. Type must be 'pangea_token' or a raw string.
kenany
reviewed
Jul 29, 2024
Member
|
Add a release note to |
Co-authored-by: Kenan Yildirim <kenan.yildirim@pangea.cloud>
pangea-andrest
approved these changes
Jul 30, 2024
Contributor
pangea-andrest
left a comment
pangea-andrest
left a comment
There was a problem hiding this comment.
Just one minor comment but approved anyway
|
|
||
| this.serviceName = serviceName; | ||
| this.token = token; | ||
| if (typeof token === "string") { |
Contributor
There was a problem hiding this comment.
Wouldn't be better to move this whole logic into a function?
Member
Author
There was a problem hiding this comment.
It's only used here, we can break it out later if more use comes. I'm not a fan of early abstraction, generally abstract only a rule of 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept Pangea token type in service constructors. Type must be 'pangea_token' or a raw string.