pangea-node-sdk: correct canonicalization of more chars (PAN-16573) #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenany
force-pushed
the
kenany/PAN-16573
branch
from
88fb14c to
6f377f0
Compare
Integration tests unveiled more canonicalization issues, this time surrounding the a-circumflex and replacement characters: <https://gitlab.com/pangeacyber/pangea-javascript/-/jobs/7734561427> This patch fixes the issue by replacing all of the custom RFC8785 code with the json-canon library. Also added unit tests to cover what was previously failing.
kenany
force-pushed
the
kenany/PAN-16573
branch
from
6f377f0 to
995458a
Compare
pangea-andrest
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests unveiled more canonicalization issues, this time surrounding the a-circumflex and replacement characters: https://gitlab.com/pangeacyber/pangea-javascript/-/jobs/7734561427
This patch fixes the issue by replacing all of the custom RFC8785 code with the json-canon library. Also added unit tests to cover what was previously failing.