Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macos to CI #513

Closed
wants to merge 41 commits into from
Closed

add macos to CI #513

wants to merge 41 commits into from

Conversation

kojix2
Copy link
Contributor

@kojix2 kojix2 commented Jun 21, 2023

Hi.

I added a workflow for macOS to Actions on GitHub based on (#494) by @sampsyo.
This workflow successfully builds odgi, but still fails testing.

@subwaystation
Copy link
Member

What is the problem here @kojix2 ? I can't see any logs.

@subwaystation
Copy link
Member

I also can't restart the CI, to reproduce the error. Weird.

@subwaystation
Copy link
Member

Could you push another commit @kojix2? I don't have the rights on your branch. Maybe also give the macos build 2 threads.

@kojix2
Copy link
Contributor Author

kojix2 commented Feb 6, 2024

Rebased commit on master branch.
I will close this pull request, but you can see the build log above.

@kojix2 kojix2 closed this Feb 6, 2024
@subwaystation
Copy link
Member

looks like a temporary file problem
how does macos handle these?

@AndreaGuarracino
Copy link
Member

It seems macos does not like stepindex:

odgi test is a Catch v2.13.7 host application.
Run with -? for options

-------------------------------------------------------------------------------
step index construction, and position retrieval.
  The index can be saved and loaded. After loading, we can retrieve all the
  correct positions again.
-------------------------------------------------------------------------------
/Users/runner/work/odgi/odgi/src/unittest/stepindex.cpp:654
...............................................................................

/Users/runner/work/odgi/odgi/src/unittest/stepindex.cpp:654: FAILED:
due to unexpected exception with message:
  [odgi::algorithms::stepindex] error: SDSL step index file does not have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants