Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve only stable releases by default. #4201

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Jan 24, 2017

Upgrade to pex 1.2.1 to pickup control over pre-release resolution and
setup resolves to use only stable releases by default.

Closes #4196

@jsirois
Copy link
Contributor Author

jsirois commented Jan 24, 2017

NB: There is one pex.resolver.resolve this does not plumb with a --pre option - the resolve used for interpreters here. I think this is sane, but opinions welcome.

Copy link
Member

@kwlzn kwlzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and seems perfectly reasonable re: the one non---pre-plumbed interpreter setup resolve.

@jsirois
Copy link
Contributor Author

jsirois commented Jan 24, 2017

Nifty, this fails the contrib shard since the contrib plugins depend on a pantsbuild.pants dev release for master builds - which is unstable, which is now disallowed by default. Fix diff coming...

@jsirois
Copy link
Contributor Author

jsirois commented Jan 24, 2017

Turns out I had missed a fourth use of the pex resolve function - in the pants plugin resolver. This now plumbs allow_prereleases as appropriate to the active pants version.

@jsirois
Copy link
Contributor Author

jsirois commented Jan 25, 2017

Removed the .travis.yml muddling - I'll rebase to pick up Stu's fix in #4205 for the timeouts.

Upgrade to pex `1.2.0` to pickup control over pre-release resolution and
setup resolves to use only stable releases by default.
@jsirois jsirois merged commit 4c14dbb into pantsbuild:master Jan 25, 2017
@jsirois jsirois deleted the jsirois/issues/4196/try2 branch January 25, 2017 21:28
peiyuwang pushed a commit to twitter/pants that referenced this pull request Feb 16, 2017
Upgrade to pex `1.2.0` to pickup control over pre-release resolution and
setup resolves to use only stable releases by default.
lenucksi pushed a commit to lenucksi/pants that referenced this pull request Apr 25, 2017
Upgrade to pex `1.2.0` to pickup control over pre-release resolution and
setup resolves to use only stable releases by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to pex support for prerelease resolution control and plumb this control through pants
2 participants