-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apogee mpu9150 baro sdlog #1498
Conversation
…autier). Also allow sdlog for airspeed_ets temp_temod and humid_sht. Examples for using this in airframe file are given in the. AULA airframes
This reverts commit 67899c7.
This reverts commit 0feb1bd.
This reverts commit 1fb237d.
This reverts commit 4f94c29.
This reverts commit 44c0c58.
…ble by Gautier)." This reverts commit 7f2381b.
@@ -150,10 +153,19 @@ bool_t mpu60x0_configure_i2c_slaves(Mpu60x0ConfigSet mpu_set, void *mpu) | |||
mpu_i2c->slave_init_status++; | |||
break; | |||
case MPU60X0_I2C_CONF_SLAVES_CONFIGURE: | |||
#ifdef MPU9150_SLV_MAG | |||
while(cpt<mpu_i2c->config.nb_slaves) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should not be done in a while loop, rather it should call mpu_i2c->config.slaves[cpt].configure(mpu_set, mpu)
once and move to the next slave if it succeeded.
That also means that cpt
would need to be static...
@philipan I don't quite understand the need to add anything special for the MPL3115 baro compared to the existing apogee driver... Could you please elaborate? |
Hi, the existing Apogee driver only supports addressing the MPL3115 if there However using Gautiers patch makes the baro work on the This all relates to the problems also discussed here: Best regards, Am 27.12.2015 um 21:06 schrieb Felix Ruess:
PD Dr. Andreas Philipp Phone: ++49/821/598-2266 http://www.geo.uni-augsburg.de/lehrstuehle/phygeo/personal/philipp/ |
Well, as @gautierhattenberger wrote, his patch needs a bit more work, otherwise he could have committed it right away... Still don't understand why the baro doesn't work in I2C pass-through mode like in the MPU60x0 case... In any case baro stuff should not be in the mpu9150_i2c.c file as it is not part of the MPU peripheral and rather in imu_apogee or probably even better in a new imu_apogee_mpu9150... |
I did wrote this myself, and my colleague was writing his first Paparazzi driver. I was not completely happy so I didn't merged it as his. |
on the other hand, the parts of this PR referring to meteo sensors logging could be merge separately (actually, it would have been easier to make a dedicated pull request for that) |
Of course I would really be extremely happy if I (and my students) could use the Apogee boards with the up-to-date pprz software without each time patching or rebasing/merging with git. However I understand that the master branch should keep a clear structure, which might be not the case for the PR as it is now. In order to include at least the logging of the sht75, temod and airspeed I can revert the recent commit and leave out the baro things for a new commit if you think this is useful. Concerning the airspeed_ets I have the problem that "sdlog.h" cannot be found for the "#include" statement in "airspeed_ets.c" if target "sim" is compiled. I tried to figure out where the problem is, but didn't find a solution. For the other modules (temod and sht) it is no problem. Further I found a problem in "conf/modules/temp_temod.xml" where the variable name "TEMOD_DEV" should be changed to "TEMOD_I2C_DEV" as far as I can see. Should this be an extra PR too? |
Thanks for the TEMOD_I2C_DEV fix, committed with 5cad5b5 |
… sd (made available by Gautier).""" This reverts commit 8875e1e. Conflicts: conf/airframes/AULA/AULA_XENO_I_01.xml conf/airframes/AULA/apogee_sdlog.xml conf/radios/AULA/mx-16-aula.xml sw/airborne/modules/meteo/temp_temod.c sw/airborne/modules/sensors/airspeed_ets.c
…ogee_mpu9150_baro_sdlog
integrated Gautiers patch to access baro on 9dofimu apogee boards and added SDLOG features for baro, sht75, airspeed_ets and temod (together with gps data). Example airframe is AULA/apogee_sdlog.xml (use together with radios/AULA/mx-16-aula.xml and fixedwing_fligh_trecoder.xml). In target sim the airspeed_ets still cannot find sdlog.h!