chore: allow empty blobparams in ethconfig #20105
Merged
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
A-rpc
klkvr
approved these changes
Dec 4, 2025
Comment on lines
79
to
89
| blob_schedule: chain_spec | ||
| .blob_params_at_timestamp(timestamp) | ||
| // no blob support, so we set this to zero | ||
| .unwrap_or(BlobParams { | ||
| target_blob_count: 0, | ||
| max_blob_count: 0, | ||
| update_fraction: 0, | ||
| min_blob_fee: 0, | ||
| max_blobs_per_tx: 0, | ||
| blob_base_cost: 0, | ||
| }), |
Member
There was a problem hiding this comment.
should this be BlobParams::cancun() instead? I guess ideally we just make it optional but not worth breaking alloy for this
yongkangc
pushed a commit
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the endpoint also work on other networks that dont have blobs and also matches what geth is doing where the blobschedule field is optional in the first place and can be "null"
we can do this manually on alloy if these are set to 0 for example
https://github.com/ethereum/go-ethereum/blob/6f2cbb7a27ba7e62b0bdb2090755ef0d271714be/params/config.go#L1173-L1193
https://github.com/ethereum/go-ethereum/blob/6f2cbb7a27ba7e62b0bdb2090755ef0d271714be/internal/ethapi/api.go#L1177-L1177