Skip to content

[plugin.from_html] Title tag is rendered #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2015
Merged

[plugin.from_html] Title tag is rendered #417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
055fd45
[plugin.from_html] Title tag is rendered
Flamenco Dec 8, 2014
cbc6f51
[plugin.from_html] Title tag is rendered
Flamenco Dec 8, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions jspdf.plugin.from_html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,10 @@
};
}
}
renderer.addText(value, fragmentCSS);
// Only add the text if the text node is in the body element
if (cn.ownerDocument.body.contains(cn)){
renderer.addText(value, fragmentCSS);
}
} else if (typeof cn === "string") {
renderer.addText(cn, fragmentCSS);
}
Expand Down Expand Up @@ -619,7 +622,9 @@
$hiddendiv.innerHTML = "<iframe style=\"height:1px;width:1px\" name=\"" + framename + "\" />";
document.body.appendChild($hiddendiv);
$frame = window.frames[framename];
$frame.document.body.innerHTML = element;
$frame.document.open();
$frame.document.writeln(element);
$frame.document.close();
return $frame.document.body;
})(element.replace(/<\/?script[^>]*?>/gi, ''));
}
Expand Down