Remove unnecessary libs from dist #716
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbengtsson
changed the title
simonbengtsson
changed the title
Merged
|
Does this still need merging now we've changed the build script? |
|
I updated it to be a clean up PR now which removes the unused |
|
Done in other commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the build script to not include requirejs, the unused
html2pdf.jsand only one version of html2canvas (previously both all files inlibs/html2canvas/srcandlibs/html2canvas/distwere included). The included requirejs ironically prevented jspdf to be used in a requirejs based applications (see last comments in #122). It must have been included by accident at some point?This is an intermediate step towards being able to make the last changes in #713 i.e. integrating a module bundler and babeljs.