Skip to content

Conversation

simonbengtsson
Copy link
Contributor

Here comes the last of the changes referenced in #713. Part from updating the build script, it makes the following changes to generated dist files:

  1. It wraps both the debug and minified file in a umd wrapper that works with all module bundlers.
  2. It makes some minor changes to allow for strict mode.
  3. It transpiles with babeljs which removes some unnecessary parentheses etc
  4. It doesn't include the same libs removed by Remove unnecessary libs from dist #716 (I think merging that one first makes most sense)

Because of these changes to the dist files I suggest publishing a new patch version (mainly because of 1.). The workflow I propose to do this would be running npm version patch and if everything looks alright then npm publish && git push --tags. The version command will build, create a commit with dist files, create a git tag and update package.json with the new version number.

@MrRio
Copy link
Member

MrRio commented Mar 24, 2016

That looks great!

@MrRio MrRio merged commit f895888 into parallax:master Mar 24, 2016
@simonbengtsson
Copy link
Contributor Author

Sweet! Can you create a new patch version and publish to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants