balance mismatch in Axelar EVM tests

[mutantcornholio]

• clone scc-testing repo
• cd axelar-gmp-sdk-solidity
• update environment to provide ETC_RPC_BIN, REVIVE_DEV_NODE_BIN and RESOLC_BIN
• run npx hardhat test --network hardhat --grep 'should deploy with native value passed to the constructor' test/deploy/Create2Deployer.js

the output is:

  1) Create2Deployer
       deploy
         should deploy with native value passed to the constructor:

      AssertionError: expected 100000000000000000010 to equal 10. The numerical values of the given "ethers.BigNumber" and "number" inputs were compared, and they differed.
      + expected - actual

      -100000000000000000010
      +10

run the same, but with polkadot: false in config, and the test passes.

[pgherveou]

looks related to the ED, should be fixed by latest master @0xRVE can you take a look

[0xRVE]

taking a look

[0xRVE]

consistently getting the following error:

axelar-gmp-sdk-solidity % yarn test
yarn run v1.22.22
$ npx hardhat test
npm warn Unknown env config "version-git-tag". This will stop working in the next major version of npm.
npm warn Unknown env config "argv". This will stop working in the next major version of npm.
npm warn Unknown env config "version-commit-hooks". This will stop working in the next major version of npm.
npm warn Unknown env config "version-git-message". This will stop working in the next major version of npm.
npm warn Unknown env config "version-tag-prefix". This will stop working in the next major version of npm.
Compiling 8 Solidity files
Compiling 7 Solidity files
Compiling 9 Solidity files
Compiling 144 Solidity files
Error: write EPIPE
    at WriteWrap.onWriteComplete [as oncomplete] (node:internal/stream_base_commons:87:19)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@bee344 Can you have a look?

[0xRVE]

yarn hardhat test --network localNode --grep 'should deploy to the predicted address' test/deploy/Create2Deployer.js
This one works if we use properly funded accounts.
For some reason this call gives the wrong accounts: [deployerWallet, userWallet] = await ethers.getSigners();

After hardcoding the accounts using the values found here it works: https://docs.rs/crate/subxt-signer/latest/source/src/eth.rs#477

replaced

+         deployerWallet = new ethers.Wallet('0x5fb92d6e98884f76de468fa3f6278f8807c48bebc13595d45af5bdc4da702133', ethers.provider);
+         userWallet = new ethers.Wallet('0x8075991ce870b93a8870eca0c0f91913d12f47948ca0fd25b49c6fa7cdbeee8b', ethers.provider);
-         [deployerWallet, userWallet] = await ethers.getSigners();

[0xRVE]

"should deploy with native value passed to the constructor"

This testcase fails because it credits the deployed contract with 10 wei but the actual balance of the contract is 10_000_000_000_000_010.

From polkadot-sdk/substrate/frame/revive/dev-node/runtime/src/lib.rs the existential deposit is 10_000_000_000.

with NativeToEthRatio = 1_000_000 that checks out.

This means that await ethers.provider.getBalance(contract.address) queries the total balance of the account which might not be what we want.

[0xRVE]

@bee344 As we discussed briefly offline: we need to decide what is the right behavior for ethers.provider.getBalance

git clone git@github.com:paritytech/polkadot-sdk.git
ln -s ./polkadot-sdk ~/polkadot-sdk
git clone git@github.com:paritytech/contracts-boilerplate.git
cd contracts-boilerplate
source scripts/node-env.sh
tmux new
dev-node build
eth-rpc build
revive_dev_stack

new terminal
make sure const usePolkavm = false in scc-testing/axelar-gmp-sdk-solidity/hardhat.config.js.

git clone git@github.com:paritytech/scc-testing.git
cd scc-testing/axelar-gmp-sdk-solidity
yarn install
yarn hardhat test --network localNode --grep 'native' test/deploy/Create2Deployer.js

result:

  0 passing (184ms)
  1 failing

  1) Create2Deployer
       deploy
         should deploy with native value passed to the constructor:

      AssertionError: expected 10000000000000010 to equal 10. The numerical values of the given "ethers.BigNumber" and "number" inputs were compared, and they differed.
      + expected - actual

      -10000000000000010
      +10

      at Context.<anonymous> (test/deploy/Create2Deployer.js:97:75)
      at processTicksAndRejections (node:internal/process/task_queues:105:5)

Reason for this failure:
dev-node has an existential balance of 10_000_000_000_000_000 wei. The test uses ethers.provider.getBalance to query the balance of the contract which calls total_balance on the dev-node.