[revm] uniswap v2-core tests fail with outofgas

[sekisamu]

Description

uniswap v2-core tests fail on revm due to OutOfGas error.

Environment

polkadot-sdk version: 0e3195df28c6b39d098d4149f9dbc78009e88493
Test repository: https://github.com/papermoonio/uniswap-v2-polkadot

Steps to Reproduce

1. Build nodes

git clone https://github.com/paritytech/polkadot-sdk
cd polkadot-sdk
git checkout 0e3195df28c6b39d098d4149f9dbc78009e88493

# Build eth-rpc
cargo build -p pallet-revive-eth-rpc --release

# Build revive-dev-node
cd substrate/frame/revive/dev-node/node
cargo build --release

IMPORTANT: Bump ALITH's balance to a very large value.

2. Prepare test repository

git clone https://github.com/papermoonio/uniswap-v2-polkadot
cd uniswap-v2-polkadot

3. Create .env file

Create .env file in the project root:

LOCAL_PRIV_KEY=0x5fb92d6e98884f76de468fa3f6278f8807c48bebc13595d45af5bdc4da702133
AH_PRIV_KEY=0x8075991ce870b93a8870eca0c0f91913d12f47948ca0fd25b49c6fa7cdbeee8b

npm install

install the depencies:

npm install

5. Run tests

remember to start the local chain manually

npx hardhat test --network local

The error:

❯ npx hardhat test --network local

npx hardhat test --network local
[dotenv@17.2.1] injecting env (2) from .env -- tip: 📡 observe env with Radar: https://dotenvx.com/radar


  UniswapV2ERC20
    ✔ name, symbol, decimals, totalSupply, balanceOf, DOMAIN_SEPARATOR, PERMIT_TYPEHASH
    ✔ approve
    ✔ transfer
    ✔ transfer:fail
    ✔ transferFrom
    ✔ transferFrom:max

  UniswapV2Factory
    ✔ feeTo, feeToSetter, allPairsLength
    1) createPair
    2) createPair:reverse
    ✔ setFeeTo
    ✔ setFeeToSetter

  UniswapV2Pair
    3) "before each" hook for "mint"


  9 passing (1s)
  3 failing

  1) UniswapV2Factory
       createPair:
     ProviderError: failed to run contract: Module(ModuleError { index: 5, error: [3, 0, 0, 0], message: Some("OutOfGas") })
      at HttpProvider.request (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/hardhat/src/internal/core/providers/http.ts:116:21)
      at processTicksAndRejections (node:internal/process/task_queues:105:5)
      at HardhatEthersProvider.estimateGas (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/internal/hardhat-ethers-provider.ts:246:27)
      at /Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:335:35
      at async Promise.all (index 0)
      at HardhatEthersSigner._sendUncheckedTransaction (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:356:7)
      at HardhatEthersSigner.sendTransaction (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:181:18)
      at send (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/ethers/src.ts/contract/contract.ts:313:20)
      at Proxy.createPair (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/ethers/src.ts/contract/contract.ts:352:16)
      at waitForPendingTransaction (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-chai-matchers/src/internal/emit.ts:28:17)

  2) UniswapV2Factory
       createPair:reverse:
     ProviderError: failed to run contract: Module(ModuleError { index: 5, error: [3, 0, 0, 0], message: Some("OutOfGas") })
      at HttpProvider.request (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/hardhat/src/internal/core/providers/http.ts:116:21)
      at processTicksAndRejections (node:internal/process/task_queues:105:5)
      at HardhatEthersProvider.estimateGas (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/internal/hardhat-ethers-provider.ts:246:27)
      at /Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:335:35
      at async Promise.all (index 0)
      at HardhatEthersSigner._sendUncheckedTransaction (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:356:7)
      at HardhatEthersSigner.sendTransaction (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:181:18)
      at send (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/ethers/src.ts/contract/contract.ts:313:20)
      at Proxy.createPair (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/ethers/src.ts/contract/contract.ts:352:16)
      at waitForPendingTransaction (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-chai-matchers/src/internal/emit.ts:28:17)

  3) UniswapV2Pair
       "before each" hook for "mint":
     ProviderError: failed to run contract: Module(ModuleError { index: 5, error: [3, 0, 0, 0], message: Some("OutOfGas") })
      at HttpProvider.request (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/hardhat/src/internal/core/providers/http.ts:116:21)
      at processTicksAndRejections (node:internal/process/task_queues:105:5)
      at HardhatEthersProvider.estimateGas (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/internal/hardhat-ethers-provider.ts:246:27)
      at /Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:335:35
      at async Promise.all (index 0)
      at HardhatEthersSigner._sendUncheckedTransaction (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:356:7)
      at HardhatEthersSigner.sendTransaction (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-ethers/src/signers.ts:181:18)
      at send (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/ethers/src.ts/contract/contract.ts:313:20)
      at Proxy.createPair (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/ethers/src.ts/contract/contract.ts:352:16)
      at waitForPendingTransaction (/Users/suvi/Documents/paritytech/papermoon/code/v2-core-polkadot/node_modules/@nomicfoundation/hardhat-chai-matchers/src/internal/emit.ts:28:17)

[sekisamu]

And I've tried to bump the calculated gas 10 times in estimateGas by modifying the code into:

	async fn estimate_gas(
		&self,
		transaction: GenericTransaction,
		block: Option<BlockNumberOrTag>,
	) -> RpcResult<U256> {
		let hash = self.client.block_hash_for_tag(block.unwrap_or_default().into()).await?;
		let runtime_api = self.client.runtime_api(hash);
		let dry_run = runtime_api.dry_run(transaction).await?;
		// Multiply estimated gas by 10 to provide buffer for gas estimation inaccuracies
		let buffered_gas = dry_run.eth_gas.saturating_mul(U256::from(10));
		Ok(buffered_gas)
	}

and still got the same error.

[sekisamu]

After some in-depth debugging, I discovered that modifying estimateGas was ineffective. This is because the transaction throwing the OutOfGas error was already failing during the dry-run stage, causing estimateGas itself to return an error. Consequently, simply increasing the return value of estimateGas in the node's code had no effect.

After briefly studying the implementation related to ETH transaction fees, I tried increasing MaxEthExtrinsicWeight to 80%, and even 95%. I found that this reduced some of the errors, but random OutOfGas errors still occurred (though on the Hardhat side, the error might be reported as revert or invalid transaction). Additionally, the node's logs would show errors like revive.TxFeeOverdraw, revive.ContractReverted, or revive.OutOfGas.

Upon a more in-depth review of the code for gas calculation and consumption, I pinpointed the issue to this function: https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/revive/src/evm/call.rs#L48

In this function, the author appears to be attempting to convert the ETH transaction fee into Substrate weight. This involves a highly complex and difficult-to-understand conversion. I tried to understand but failed.

However, my overall conclusion is that Substrate imposes stricter gas limits on ETH transactions. For example, for a single ETH transaction, there is a strict proportional constraint between the ETH transaction fee component and the Substrate transaction fee. Furthermore, unlike Ethereum's model, Substrate also imposes a weight limit on individual transactions. This makes OutOfGas errors more prone to occur.

polkadot-sdk version: b21cbb58ab50d5d10371393967537f6f221bb92f

[athei]

I am trying to reproduce. Did:

npm install
npx hardhat test --network local

But getting this error:

An unexpected error occurred:

Error: Cannot find module '@nomicfoundation/solidity-analyzer-darwin-arm64'
Require stack:
- /Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/solidity-analyzer/index.js
- /Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/ignition-core/dist/src/verify.js
- /Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/ignition-core/dist/src/index.js
- /Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/hardhat-ignition/dist/src/index.js
- /Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/hardhat-ignition-ethers/dist/src/index.js
- /Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/hardhat-toolbox/index.js
- /Users/alexander/Downloads/uniswap-v2-polkadot/hardhat.config.js
- /Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/hardhat/internal/core/config/config-loading.js
- /Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/hardhat/internal/cli/cli.js
- /Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/hardhat/internal/cli/bootstrap.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1420:15)
    at defaultResolveImpl (node:internal/modules/cjs/loader:1058:19)
    at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1063:22)
    at Module._load (node:internal/modules/cjs/loader:1226:37)
    at TracingChannel.traceSync (node:diagnostics_channel:328:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:244:24)
    at Module.require (node:internal/modules/cjs/loader:1503:12)
    at require (node:internal/modules/helpers:152:16)
    at Object.<anonymous> (/Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/solidity-analyzer/index.js:152:29)
    at Module._compile (node:internal/modules/cjs/loader:1760:14) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/solidity-analyzer/index.js',
    '/Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/ignition-core/dist/src/verify.js',
    '/Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/ignition-core/dist/src/index.js',
    '/Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/hardhat-ignition/dist/src/index.js',
    '/Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/hardhat-ignition-ethers/dist/src/index.js',
    '/Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/@nomicfoundation/hardhat-toolbox/index.js',
    '/Users/alexander/Downloads/uniswap-v2-polkadot/hardhat.config.js',
    '/Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/hardhat/internal/core/config/config-loading.js',
    '/Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/hardhat/internal/cli/cli.js',
    '/Users/alexander/Downloads/uniswap-v2-polkadot/node_modules/hardhat/internal/cli/bootstrap.js'
  ]
}

[sekisamu]

@athei what is your node version and npm version?

[athei]

$ npm --version
11.6.0
$ node --version
v24.10.0

[sekisamu]

this is my config, hope that would help:

❯ node -v
v22.18.0
❯ npm --version
10.9.3

[athei]

Downgrading the npm version to 22 worked. But had to also delete the node_modules after downgrading to fix.

[athei]

Okay I debugged this. The reason seems to be that the call is heavier than the MaxEthExtrinsicWeight. This is already applied in the dry run. When I change from 50% to 90% the tests do work.

pub const MaxEthExtrinsicWeight: FixedU128 = FixedU128::from_rational(9, 10);

I will add better logging to understand this better. But is creating a pair such an expensive operation? Probably create2 charging a lot of gas.

[albertov19]

But is creating a pair such an expensive operation? Probably create2 charging a lot of gas.

On Sepolia, it is about 2.5M gas units. On Moonbeam, about 3.7M gas units. That is only creating the pair. But when you actually create a pool you createPair but also add liquidity, and the transaction can be a bit bigger. But I'm guessing for us the main problem is related to the storage created

[athei]

Debugging why this call is so expensive falls under optimization. As long as it fits as of right now I will still close. By glancing over it nothing really expensive seems to happen in the constructor and initialize function. This will take a lot of time to find out.

But I'm guessing for us the main problem is related to the storage created

It is expensive in ref_time. So this is not due to storage deposit.