A contract calling itself with some eth `value` can cause the value to be lost.

[0xOmarA]

We've noticed an issue in one of the tests where one contract calls itself with some eth value and the eth balance it ends up with is less than what it started with, essentially allowing the eth to be lost/burned.

Tests impacted by this are:

• translated_semantic_tests/functionCall/call_options_overload/test.json::0::E-

[pgherveou]

can you give the path in the description relative to the root of the differential-tests repo

./resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/functionCall/call_options_overload/test.json

in that case

[pgherveou]

@0xRVE can you take a look

that's how I test this loading the latest node-env.sh script from contracts-boilerplates

# build dev-node with chainspec setup for retester
dev-node build --retester

# start the server with the dev-node built above
revive_dev_stack --retester

# run the test 
retester_test "./resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/functionCall/call_options_overload/test.json::0::E-"

[pgherveou]

you can also just

revive_dev_stack --retester

and launch

~/github/contracts-boilerplate 
❯ ./scripts/re-run-all.sh /tmp/retester-1.txt
   1 - Sending from: 0x81e2a30394e23d7075353b19030394a07ba5e7b5 nonce:    0 0x7d358d49d51dadf3f1bf7ed47aa0ce4e93641463ebd4fc896cdf4dda13921b5d status: ✓
   2 - Sending from: 0x81e2a30394e23d7075353b19030394a07ba5e7b5 nonce:    1 0x535079d0bfa7ed9f933ab543feae1d8cb1403172ef3cce1786688bdaf6fdae5c status: ✓
   3 - Sending from: 0x81e2a30394e23d7075353b19030394a07ba5e7b5 nonce:    2 0xce193105d9392a00523e3ad719433ce3b4dd2a3982c6e4cf1faf2a4e6c4f56f2 status: ✓
   4 - Sending from: 0x81e2a30394e23d7075353b19030394a07ba5e7b5 nonce:    3 0x9a60fb612e6fb173c09a034791bf93610327006c2ef06c60b733a99827fdea64 status: ✓

with /tmp/retester-1.txt being the recording of the test above producing this file

{"jsonrpc":"2.0","id":3,"method":"eth_sendRawTransaction","params":["0x02f905de84190f1b448001831e848185fc7fd492288080b905846080604052348015600e575f5ffd5b506105688061001c5f395ff3fe608060405260043610610042575f3560e01c806313d1aa2e1461004d57806328b5e32b1461007d5780633d79d1c81461009e578063b3de648b146100c857610049565b3661004957005b5f5ffd5b61006760048036038101906100629190610364565b6100f8565b60405161007491906103b1565b60405180910390f35b610085610103565b60405161009594939291906103ca565b60405180910390f35b3480156100a9575f5ffd5b506100b261031c565b6040516100bf91906103b1565b60405180910390f35b6100e260048036038101906100dd919061040d565b610323565b6040516100ef91906103b1565b60405180910390f35b5f6002905092915050565b5f5f5f5f3073ffffffffffffffffffffffffffffffffffffffff1663b3de648b600a60026040518363ffffffff1660e01b8152600401610143919061047a565b60206040518083038185885af115801561015f573d5f5f3e3d5ffd5b50505050506040513d601f19601f8201168201806040525081019061018491906104a7565b93503073ffffffffffffffffffffffffffffffffffffffff166313d1aa2e612710600260036040518463ffffffff1660e01b81526004016101c692919061050b565b6020604051808303815f8887f11580156101e2573d5f5f3e3d5ffd5b50505050506040513d601f19601f8201168201806040525081019061020791906104a7565b92503073ffffffffffffffffffffffffffffffffffffffff166313d1aa2e612710600a600260036040518563ffffffff1660e01b815260040161024b92919061050b565b602060405180830381858988f1158015610267573d5f5f3e3d5ffd5b5050505050506040513d601f19601f8201168201806040525081019061028d91906104a7565b91503073ffffffffffffffffffffffffffffffffffffffff166313d1aa2e600a61271090600260036040518563ffffffff1660e01b81526004016102d292919061050b565b602060405180830381858988f11580156102ee573d5f5f3e3d5ffd5b5050505050506040513d601f19601f8201168201806040525081019061031491906104a7565b905090919293565b5f47905090565b5f60019050919050565b5f5ffd5b5f819050919050565b61034381610331565b811461034d575f5ffd5b50565b5f8135905061035e8161033a565b92915050565b5f5f6040838503121561037a5761037961032d565b5b5f61038785828601610350565b925050602061039885828601610350565b9150509250929050565b6103ab81610331565b82525050565b5f6020820190506103c45f8301846103a2565b92915050565b5f6080820190506103dd5f8301876103a2565b6103ea60208301866103a2565b6103f760408301856103a2565b61040460608301846103a2565b95945050505050565b5f602082840312156104225761042161032d565b5b5f61042f84828501610350565b91505092915050565b5f819050919050565b5f819050919050565b5f61046461045f61045a84610438565b610441565b610331565b9050919050565b6104748161044a565b82525050565b5f60208201905061048d5f83018461046b565b92915050565b5f815190506104a18161033a565b92915050565b5f602082840312156104bc576104bb61032d565b5b5f6104c984828501610493565b91505092915050565b5f819050919050565b5f6104f56104f06104eb846104d2565b610441565b610331565b9050919050565b610505816104db565b82525050565b5f60408201905061051e5f83018561046b565b61052b60208301846104fc565b939250505056fea26469706673582212203393cff536ab153f705261ab1842b6357f2cf09b6ec210518dc5711ba30333df64736f6c634300081d0033c001a0f5663a5539bc660279f3aad639a0c01629aed9fc9310091e5ac2eb0b73de9e8ea0111664f5ab616b76b1561229158e15722da6219ac51040afadbc3faf9a7918a7"]}
{"jsonrpc":"2.0","id":8,"method":"eth_sendRawTransaction","params":["0x02f87484190f1b440101831e848185040939d7219437ada325565c69e87002d56b936f444086cbc92c880de0b6b3a764000080c001a0f57af3c8aee442a7ab0cc0d013576a4034daadc8d5b1a541bcde29ef3b652f5ca01ae0a0017acd83373dd24111a67eb6aec02ca9d060fbe207665dec14517c70fb"]}
{"jsonrpc":"2.0","id":14,"method":"eth_sendRawTransaction","params":["0x02f87084190f1b440201831e8481850469779bfb9437ada325565c69e87002d56b936f444086cbc92c808428b5e32bc080a0c4b7132af8e52a6be9c44d11141fb9430ebf0e59544fae27f8d97639f33040b9a01101d60aad6ecf62a59d7d950a275d76e856ea31bc937eae1cc711d1ab6a1e97"]}
{"jsonrpc":"2.0","id":20,"method":"eth_sendRawTransaction","params":["0x02f86f84190f1b440301831e84818503edeea7699437ada325565c69e87002d56b936f444086cbc92c80843d79d1c8c0809fb80078dd1e2f9c6e6489c8a5621e9180928b42abb4a48e9d376f7721abfcc1a02385cca332a5e01b353adc327de57187b425076aea6c0ba1f241d2bd611b708d"]}

[0xRVE]

👀

[pgherveou]

that's a good one thanks @0xOmarA

[0xRVE]

This call function in revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/functionCall/call_options_overload/call_options_overload.sol sends some funds to its own address:

    function call() public payable returns (uint v, uint x, uint y, uint z) {
        v = this.f{value: 10}(2);
        x = this.f{gas: 10000}(2, 3);
        y = this.f{gas: 10000, value: 10}(2, 3);
        z = this.f{value: 10, gas: 10000}(2, 3);
    }

Changed it to this for testing some numbers:

    function call() public payable returns (uint v, uint x, uint y, uint z) {
        // case 1
        // this.f{value: 1}(2); // FAIL: we end up with 999999999999999000001 wei

        // case 2
        // this.f{value: 1_000_000}(2); // PASS: we end up with 1000000000000000000000 wei

        // case 3
        // this.f{value: 999_999}(2); // FAIL: we end up with 999999999999999999999 wei

        // case 4
        // this.f{value: 1_000_001}(2); // FAIL: we end up with 999999999999999000001 wei (same as sending 1 wei)

        // case 5
        // this.f{value: 1}(2);
        // this.f{value: 999_999}(2); // FAIL: we end up with 999999999999999000000 wei

        // case 6
        // this.f{value: 500_000}(2); // FAIL: we end up with 999999999999999500000 wei

        // case 7
        // this.f{value: 2_000_000}(2); // PASS

        // case 8
        // this.f{value: 500_001}(2); // FAIL: we end up with 999999999999999500001 wei
        
        // case 9
        // this.f{value: 499_999}(2); // FAIL: we end up with 999999999999999499999 wei

        // case 10
        // this.f{value: 500_001}(2);
        // this.f{value: 499_999}(2); // PASS

        // case 11
        // this.f{value: 500_000}(2);
        // this.f{value: 500_000}(2); // PASS

        // case 12
        this.f{value: 100_000}(2);
        this.f{value: 900_000}(2); // FAIL: we end up with 999999999999999000000 wei
    }

The expected return value in revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/functionCall/call_options_overload/test.json is 0x00..100..200..200..2 But I changed it to 0x00..0 for debugging.

In some cases the funds disappear but not in all cases.