Add archive node description #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description for archive nodes was missing.
josepot
reviewed
Nov 20, 2023
| - Full nodes, which hold in their database all block headers and bodies, plus the storage of recent blocks. | ||
| - Light clients, which only know the headers of recent blocks. | ||
| - Archive nodes, which hold. | ||
| - Archive nodes, which hold in their database all block headers and bodies, plus the storage of every past block. |
Contributor
There was a problem hiding this comment.
Thanks for noticing this @IkerAlus !
However, I'm afraid that the explanation of "Full nodes" is also off. It should probably say something more or less like:
- Full nodes, which hold in their database all headers from the genesis block to the most recent block, plus the bodies and storage of the most recent blocks (typically the latest 256).
Basically, I'm quite certain that it's not true that "full nodes" hold all the bodies from genesis. I'm pretty sure that they only store the headers, which is what it's needed to validate that the state is correct.
Then IMO the "Archive nodes" description should read something more or less like this:
- Archive nodes, which hold in their database all block headers, bodies, and storage of every past block.
Contributor
Author
There was a problem hiding this comment.
yes, I think you are right respect to full nodes description.
I will change it as you suggest in this PR. Thanks!
tomaka
reviewed
Nov 20, 2023
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description for archive nodes was missing.