Skip to content

Bump to latest version #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 8, 2024
Merged

Bump to latest version #221

merged 16 commits into from
Feb 8, 2024

Conversation

@pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Jan 15, 2024

No description provided.

pgherveou
pgherveou commented Jan 15, 2024
View reviewed changes
pgherveou
pgherveou commented Jan 15, 2024
View reviewed changes
@ascjones
Copy link
Contributor

ascjones commented Jan 16, 2024

CI failing though

@pgherveou pgherveou requested a review from a team as a code owner January 16, 2024 14:42
@pgherveou
Copy link
Contributor Author

pgherveou commented Jan 17, 2024

I am going to wait before merging this,
The build requires for now to hardcode this environment variable.
Looks like the problem might be solved on master and in upcoming crate.io release

substrate-contracts-node/.gitlab-ci.yml

Lines 23 to 26 in be83efe

GIT_STRATEGY: fetch
GIT_DEPTH: 100
CARGO_INCREMENTAL: 0
WASMTIME 8.0.1

@ascjones
Copy link
Contributor

ascjones commented Feb 2, 2024

Looks like the problem might be solved on master and in upcoming crate.io release

Has this been done? I see there is e.g. a new version of https://crates.io/crates/pallet-contracts/27.0.0 released 10 days ago

@pgherveou
Copy link
Contributor Author

pgherveou commented Feb 2, 2024 •
edited
Loading

Looks like the problem might be solved on master and in upcoming crate.io release

Yes it's solved on master not on the crates.io packages.
We can merge this PR if we are fine with giving up cargo releases
I haven't worked on updating the doc regarding it, nor created a process to use crates when they are released

edit: Looks like jobs are failing, works fine locally will double check why

pgherveou
pgherveou commented Feb 8, 2024
View reviewed changes
@pgherveou pgherveou merged commit b8c1513 into main Feb 8, 2024
@pgherveou pgherveou deleted the pg/bump-to-latest-version branch February 8, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smiasojed smiasojed smiasojed approved these changes

@cmichi cmichi Awaiting requested review from cmichi

@athei athei Awaiting requested review from athei athei is a code owner

@SkymanOne SkymanOne Awaiting requested review from SkymanOne

+2 more reviewers

@ascjones ascjones ascjones approved these changes

@sergejparity sergejparity sergejparity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pgherveou @ascjones @smiasojed @sergejparity