Skip to content

fix wrong appVersion #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2020
Merged

fix wrong appVersion #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
675f363
added appBuild to installation properties
mtrezza Jun 10, 2020
c196b62
changing appVersion to contain app build instead of version name
mtrezza Jun 10, 2020
316aacb
added change log breaking change entry
mtrezza Jun 10, 2020
b38917a
fixed wrong PR link in change log
mtrezza Jun 10, 2020
b9aa6ad
Merge branch 'master' into fix-wrong-app-version
Jawnnypoo Jun 17, 2020
a6a5726
Merge remote-tracking branch 'upstream/master' into fix-wrong-app-ver…
mtrezza Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parse/src/main/java/com/parse/ParseInstallation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ private void updateVersionInfo() {
String packageName = context.getPackageName();
PackageManager pm = context.getPackageManager();
PackageInfo pkgInfo = pm.getPackageInfo(packageName, 0);
String appVersion = pkgInfo.versionName;
String appVersion = String.valueOf(pkgInfo.versionCode);
String appName = pm.getApplicationLabel(pm.getApplicationInfo(packageName, 0)).toString();

if (packageName != null && !packageName.equals(get(KEY_APP_IDENTIFIER))) {
Expand Down
2 changes: 1 addition & 1 deletion parse/src/test/java/com/parse/ParseInstallationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ public void testUpdateBeforeSave() throws Exception {
String packageName = context.getPackageName();
PackageManager pm = context.getPackageManager();
PackageInfo pkgInfo = pm.getPackageInfo(packageName, 0);
String appVersion = pkgInfo.versionName;
String appVersion = String.valueOf(pkgInfo.versionCode);
String appName = pm.getApplicationLabel(pm.getApplicationInfo(packageName, 0)).toString();
assertEquals(packageName, installation.getString(KEY_APP_IDENTIFIER));
assertEquals(appName, installation.getString(KEY_APP_NAME));
Expand Down