[android] Remove ParseRequest defaultClient #180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need defaultClient as a global state in class ParseRequest anymore.
Contributor
There was a problem hiding this comment.
This defeats the purpose of injection as it makes it difficult to unit test execution paths that use this method.
In reality, we should be passing the client through to anything that was using ParseRequest#executeAsync() and ParseRequest#executeAsync(ProgressCallback, ProgressCallback, CancellationToken).
Contributor
There was a problem hiding this comment.
nit: let's grab restClient once and reuse the same variable
Contributor
|
Could you also see if this resolves #37? |
Contributor
|
LGTM, mind squashing? |
Contributor
|
Squashed in #214 |
|
@YaoPersonal updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need defaultClient as a global state in class ParseRequest anymore.