Skip to content

Conversation

@rogerhu
Copy link
Contributor

@rogerhu rogerhu commented May 17, 2017

We can kill the JAR-related config section later

The original exclude pattern...not sure if we need to reintroduce it except for Manifest.

         exclude '**/R.class'
         exclude '**/R\$*.class'
         exclude '**/Manifest.class'
         exclude '**/Manifest\$*.class'
         exclude '**/BuildConfig.class'
     }

@hermanliang

@rogerhu rogerhu force-pushed the exclude branch 2 times, most recently from 9f92b9a to 4f3167f Compare May 17, 2017 04:25
@codecov
Copy link

codecov bot commented May 17, 2017

Codecov Report

Merging #667 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #667   +/-   ##
=========================================
  Coverage     52.86%   52.86%           
  Complexity     1676     1676           
=========================================
  Files           131      131           
  Lines         10150    10150           
  Branches       1408     1408           
=========================================
  Hits           5366     5366           
  Misses         4341     4341           
  Partials        443      443

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e51014...a6405bc. Read the comment docs.

@rogerhu rogerhu merged commit d44fdfc into parse-community:master May 17, 2017
@hermanliang
Copy link
Contributor

Nice, I think it can solve the conflict BuildConfig.class with LiveQuery's aar.
parse-community/ParseLiveQuery-Android#60

@rogerhu
Copy link
Contributor Author

rogerhu commented May 17, 2017

Hmm didn't help...BuildConfig is still in there.

@rogerhu
Copy link
Contributor Author

rogerhu commented May 17, 2017

Actually that makes sense...we have a BuildConfig dependency in the code that I added to avoid having to update this constant all the time (https://github.com/parse-community/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ParseObject.java#L56)

May have to remove it so we don't need it.

@Jawnnypoo
Copy link
Member

Isn't it not supposed to be allowed in a Java/Android project to have two library modules that share the same package name though? I think I remember this causing problems for me in the past. Maybe we need to change ParseLiveQuery to have a different package name from this SDK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants