Upgrade instructions to FCM #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerhu
force-pushed
the
upgrade
branch
5 times, most recently
from
da1b656 to
55ee582
Compare
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
=========================================
Coverage 53.46% 53.46%
Complexity 1682 1682
=========================================
Files 124 124
Lines 9852 9852
Branches 1380 1380
=========================================
Hits 5267 5267
Misses 4156 4156
Partials 429 429Continue to review full report at Codecov.
|
rogerhu
force-pushed
the
upgrade
branch
10 times, most recently
from
3748a08 to
b9b1c0d
Compare
Jawnnypoo
approved these changes
May 4, 2018
README.md
Outdated
| implementation "com.parse:parse-android:$parseVersion" | ||
| // Add for push notification support -- add FCM or GCM but not both. | ||
| implementation "com.parse:parse-fcm-android:1.17.0-$parseVersion" // migrate to FCM |
Member
There was a problem hiding this comment.
These are malformed, should just be $parseVersion
Contributor
Author
|
fixed, rebased -- please take a look. I plan to merge and deploy assuming we can also coordinate Parse docs. @flovilmart |
Member
|
Okay sweet, looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.