Delete issue

[cjosepha]

Added tests for #825

[flovilmart]

@dangtz you're starting to get how it's done! That's really appreciated you open those PR's.

[cjosepha]

@flovilmart I can't figure out why testFailingSave() is successful in Android Studio when I launch ParseObjectTest tests, but fails when launching all tests via gradle command (as you can see on Travis).
I would like to keep this non-regression test so I will add a commit to make it work, but not sure it's the right way to fix this.

[flovilmart]

Perhaps a side effect between the tesTs, state that is leaking from the previous one or something like that?

[cjosepha]

Yes it seems to be a side effect between test classes.

[codecov]

Codecov Report

Merging #832 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #832      +/-   ##
===========================================
+ Coverage     54.24%   54.5%   +0.25%     
- Complexity     1697    1705       +8     
===========================================
  Files           123     123              
  Lines          9783    9785       +2     
  Branches       1371    1372       +1     
===========================================
+ Hits           5307    5333      +26     
+ Misses         4042    4023      -19     
+ Partials        434     429       -5

Impacted Files	Coverage Δ	Complexity Δ
Parse/src/main/java/com/parse/ParseObject.java	51.15% <100%> (+0.2%)	205 <0> (ø)	⬇️
...arse/src/main/java/com/parse/ParseRESTCommand.java	83.18% <0%> (+0.45%)	52% <0%> (+1%)	⬆️
Parse/src/main/java/com/parse/Parse.java	21.35% <0%> (+0.52%)	11% <0%> (+1%)	⬆️
...in/java/com/parse/CachedCurrentUserController.java	91.37% <0%> (+0.86%)	15% <0%> (+1%)	⬆️
...arse/src/main/java/com/parse/ParseObjectCoder.java	75.6% <0%> (+4.87%)	11% <0%> (+1%)	⬆️
...arse/src/main/java/com/parse/ParseCorePlugins.java	60.55% <0%> (+5%)	47% <0%> (+2%)	⬆️
Parse/src/main/java/com/parse/FileObjectStore.java	86.84% <0%> (+5.26%)	9% <0%> (ø)	⬇️
...rc/main/java/com/parse/ParseRESTObjectCommand.java	94.73% <0%> (+31.57%)	7% <0%> (+2%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76df4ae...655b6d1. Read the comment docs.

[coveralls]

Coverage increased (+0.2%) to 58.896% when pulling 655b6d1 on DanGTZ:delete-issue into 76df4ae on parse-community:master.

[flovilmart]

Awesome! I’ll let @Jawnnypoo and @rogerhu have a look at the code!

[Jawnnypoo]

@dangtz Looks good! Correct me if I am wrong, but it looks like you found a fix for #825 in throwing that task error?

[cjosepha]

@Jawnnypoo exactly! As mentioned in the commit message 8b02505

Waiting for review and merging.

[cjosepha]

@Jawnnypoo why did the merge failed ? It's OK on my side, build and all tests passe.

[Jawnnypoo]

Unrelated to the build or the repo, looks like it was something to do with an artifact not being able to be fetched (http error)

[rogerhu]

can you add a space between the equal ('=')?

[cjosepha]

Ok. I copy-pasted these lines from here and kept the original style. Must I make this change on ParseUserTest.java too?

[rogerhu]

Please rebase. :)

[cjosepha]

@rogerhu is all ok now ?

[Jawnnypoo]

Thanks @dangtz !