Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Dec 1, 2025

Pull Request

Summary by CodeRabbit

  • Chores

    • Add Node.js 24 to supported runtime range so the project runs on Node 24 in addition to previous versions.
    • CI workflows updated to use the latest checkout and setup actions for consistent builds.
  • Documentation

    • README updated to reflect Node.js 24 compatibility and its end-of-life date.

✏️ Tip: You can customize this high-level summary in your review settings.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 1, 2025

🚀 Thanks for opening this pull request!

@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

📝 Walkthrough

Walkthrough

Adds Node.js 24 support and updates GitHub Actions usage to v4 for checkout and setup-node across CI and release workflows; updates package.json engines and README compatibility badges/tables accordingly.

Changes

Cohort / File(s) Summary
CI workflow updates
.github/workflows/ci.yml
Replaced actions/checkout@v3actions/checkout@v4, ensured actions/setup-node@v4 usage, and added Node 24 (NODE_VERSION: 24.1.0) to the CI matrix.
Release workflow update
.github/workflows/release-manual-docs.yml
Replaced actions/checkout@v3actions/checkout@v4 in the release/manual docs workflow.
Package engine bump
package.json
Updated engines.node to include Node 24: `"18
Documentation
README.md
Added Node 24 to the compatibility badge and compatibility table (v24.0.0, EOL Apr 2028).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to:
    • All occurrences of actions/checkout and actions/setup-node to confirm consistent v4 pinning.
    • CI matrix entries and any matrix-driven steps that reference node versions.
    • package.json syntax and compatibility with publishing tooling.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete; it lacks the Issue, Approach, and Tasks sections required by the template, providing only the repository guidance header. Complete the missing sections: fill in the 'Closes' field with a linked issue, describe the approach and changes made, and indicate the status of test and documentation tasks.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: Add Node 24 support' is concise and clearly describes the main change—adding Node 24 support—which aligns with the changeset modifications to CI workflows, README, and package.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 284b97a and 729397d.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • .github/workflows/ci.yml (5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build (Node 22, 22.4.1)
  • GitHub Check: build (Node 18, 18.20.4)
  • GitHub Check: build (Node 24, 24.1.0)
  • GitHub Check: build (Node 20, 20.15.1)
🔇 Additional comments (2)
.github/workflows/ci.yml (2)

86-87: Node 24.1.0 version is valid and properly formatted.

This resolves the previous critical issue: Node 24.1.0 is a valid release with proper semantic versioning that matches the pattern of other matrix entries (18.20.4, 20.15.1, 22.4.1). The version is now complete and will work correctly in the CI matrix.


14-14: GitHub Actions v4 updates are consistent and well-aligned.

All checkout and setup-node actions have been consistently updated to v4 across all jobs. setup-node@v4 with node-version input is the recommended pattern for matrix-based Node testing, and this workflow follows best practices. The configuration supports Node 24 properly through the matrix parameter, which aligns with official GitHub documentation.

Also applies to: 24-24, 26-26, 39-39, 41-41, 52-52, 54-54, 65-65, 67-67, 92-92, 94-94


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Dec 1, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (ced23ad) to head (729397d).
⚠️ Report is 2 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #2808   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          64       64           
  Lines        6222     6222           
  Branches     1489     1473   -16     
=======================================
  Hits         6215     6215           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ced23ad and 284b97a.

📒 Files selected for processing (4)
  • .github/workflows/ci.yml (5 hunks)
  • .github/workflows/release-manual-docs.yml (1 hunks)
  • README.md (2 hunks)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build (Node 24, 24)
  • GitHub Check: build (Node 18, 18.20.4)
  • GitHub Check: build (Node 20, 20.15.1)
  • GitHub Check: build (Node 22, 22.4.1)
🔇 Additional comments (6)
package.json (1)

119-119: Good alignment with CI and documentation updates.

The engines.node field correctly adds Node 24 support and maintains consistency with the README documentation and CI matrix changes.

.github/workflows/release-manual-docs.yml (1)

14-14: Consistent with broader GitHub Actions v4 upgrade.

The checkout action upgrade to v4 aligns with the CI workflow upgrades and ensures compatibility with Node 24 releases.

README.md (2)

10-10: Badge updated to reflect Node 24 support.

The compatibility badge now correctly includes Node 24 alongside the other supported LTS versions.


57-57: Node.js 24 EOL date is accurate.

The README.md entry listing Node.js 24 with an EOL date of April 2028 aligns with the official Node.js LTS schedule (April 30, 2028). No changes needed.

.github/workflows/ci.yml (2)

14-14: GitHub Actions v3→v4 upgrades look good.

All actions/checkout references have been consistently upgraded from v3 to v4 across jobs (check-lock-file-version, check-types, check-docs, check-circular, check-lint, build). These upgrades ensure compatibility with Node 24 and benefit from v4 improvements.

Also applies to: 24-24, 39-39, 52-52, 65-65, 92-92


26-26: GitHub Actions setup-node v3→v4 upgrades look good.

All actions/setup-node references have been consistently upgraded from v3 to v4 across jobs. This maintains consistency with the checkout action upgrades and ensures reliable Node version management for Node 24.

Also applies to: 41-41, 54-54, 67-67, 94-94

@mtrezza mtrezza merged commit 2794b73 into parse-community:alpha Dec 1, 2025
14 checks passed
@mtrezza mtrezza deleted the feat/node24 branch December 1, 2025 11:27
parseplatformorg pushed a commit that referenced this pull request Dec 1, 2025
# [7.1.0-alpha.1](7.0.2...7.1.0-alpha.1) (2025-12-01)

### Features

* Add Node 24 support ([#2808](#2808)) ([2794b73](2794b73))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Dec 1, 2025
parseplatformorg pushed a commit that referenced this pull request Dec 1, 2025
# [7.1.0](7.0.2...7.1.0) (2025-12-01)

### Features

* Add Node 24 support ([#2808](#2808)) ([2794b73](2794b73))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants