-
-
Notifications
You must be signed in to change notification settings - Fork 600
feat: Add Node 24 support #2808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughAdds Node.js 24 support and updates GitHub Actions usage to v4 for checkout and setup-node across CI and release workflows; updates package.json engines and README compatibility badges/tables accordingly. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #2808 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 64 64
Lines 6222 6222
Branches 1489 1473 -16
=======================================
Hits 6215 6215
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/ci.yml(5 hunks).github/workflows/release-manual-docs.yml(1 hunks)README.md(2 hunks)package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build (Node 24, 24)
- GitHub Check: build (Node 18, 18.20.4)
- GitHub Check: build (Node 20, 20.15.1)
- GitHub Check: build (Node 22, 22.4.1)
🔇 Additional comments (6)
package.json (1)
119-119: Good alignment with CI and documentation updates.The engines.node field correctly adds Node 24 support and maintains consistency with the README documentation and CI matrix changes.
.github/workflows/release-manual-docs.yml (1)
14-14: Consistent with broader GitHub Actions v4 upgrade.The checkout action upgrade to v4 aligns with the CI workflow upgrades and ensures compatibility with Node 24 releases.
README.md (2)
10-10: Badge updated to reflect Node 24 support.The compatibility badge now correctly includes Node 24 alongside the other supported LTS versions.
57-57: Node.js 24 EOL date is accurate.The README.md entry listing Node.js 24 with an EOL date of April 2028 aligns with the official Node.js LTS schedule (April 30, 2028). No changes needed.
.github/workflows/ci.yml (2)
14-14: GitHub Actions v3→v4 upgrades look good.All
actions/checkoutreferences have been consistently upgraded from v3 to v4 across jobs (check-lock-file-version, check-types, check-docs, check-circular, check-lint, build). These upgrades ensure compatibility with Node 24 and benefit from v4 improvements.Also applies to: 24-24, 39-39, 52-52, 65-65, 92-92
26-26: GitHub Actions setup-node v3→v4 upgrades look good.All
actions/setup-nodereferences have been consistently upgraded from v3 to v4 across jobs. This maintains consistency with the checkout action upgrades and ensures reliable Node version management for Node 24.Also applies to: 41-41, 54-54, 67-67, 94-94
# [7.1.0-alpha.1](7.0.2...7.1.0-alpha.1) (2025-12-01) ### Features * Add Node 24 support ([#2808](#2808)) ([2794b73](2794b73))
|
🎉 This change has been released in version 7.1.0-alpha.1 |
# [7.1.0](7.0.2...7.1.0) (2025-12-01) ### Features * Add Node 24 support ([#2808](#2808)) ([2794b73](2794b73))
|
🎉 This change has been released in version 7.1.0 |
Pull Request
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.