-
-
Notifications
You must be signed in to change notification settings - Fork 599
refactor: Upgrade puppeteer to 23.5.0 #2297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade puppeteer to 23.5.0 #2297
Conversation
Thanks for opening this pull request! |
There is some test refactor needed. |
@mtrezza please take a look again |
Waiting for CI... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2297 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 61 64 +3
Lines 6186 6392 +206
Branches 1499 1524 +25
==========================================
+ Hits 6186 6392 +206 ☔ View full report in Codecov by Sentry. |
I've reverted the package-lock file to v2. So we can do the lock-file upgrade to v3 in a separate PR at some point. |
ok cool, looks like the CI changes have passed |
Thanks for the PR! |
🎉 This change has been released in version 5.3.0-alpha.5 |
🎉 This change has been released in version 6.0.0 |
Pull Request
Issue
Issue
Closes: 2247
Approach
Upgrades the puppeteer version, this has been tested with node versions
18.20.4
,20.15.1
and22.4.1
Tasks