Skip to content

Conversation

abdullateef97
Copy link
Contributor

@abdullateef97 abdullateef97 commented Oct 7, 2024

Pull Request

Issue

Issue

Closes: 2247

Approach

Upgrades the puppeteer version, this has been tested with node versions 18.20.4, 20.15.1 and 22.4.1

Tasks

Copy link

parse-github-assistant bot commented Oct 7, 2024

Thanks for opening this pull request!

@abdullateef97 abdullateef97 changed the title Upgrades puppeteer to v23.5.0 Fix: Upgrades puppeteer to v23.5.0 Oct 7, 2024
@abdullateef97 abdullateef97 changed the title Fix: Upgrades puppeteer to v23.5.0 fix: Upgrades puppeteer to v23.5.0 Oct 7, 2024
@abdullateef97 abdullateef97 mentioned this pull request Oct 7, 2024
3 tasks
@mtrezza mtrezza changed the title fix: Upgrades puppeteer to v23.5.0 refactor: Upgrade puppeteer to 23.5.0 Oct 8, 2024
@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2024

There is some test refactor needed.

@abdullateef97
Copy link
Contributor Author

@mtrezza please take a look again

@mtrezza
Copy link
Member

mtrezza commented Oct 14, 2024

Waiting for CI...

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b50790a) to head (a19baae).
Report is 280 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##             alpha     #2297    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        64     +3     
  Lines         6186      6392   +206     
  Branches      1499      1524    +25     
==========================================
+ Hits          6186      6392   +206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza
Copy link
Member

mtrezza commented Oct 14, 2024

I've reverted the package-lock file to v2. So we can do the lock-file upgrade to v3 in a separate PR at some point.

@abdullateef97
Copy link
Contributor Author

I've reverted the package-lock file to v2. So we can do the lock-file upgrade to v3 in a separate PR at some point.

ok cool, looks like the CI changes have passed

@mtrezza mtrezza merged commit bd531a1 into parse-community:alpha Oct 14, 2024
12 checks passed
@mtrezza
Copy link
Member

mtrezza commented Oct 14, 2024

Thanks for the PR!

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.5

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 11, 2025
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to puppeteer 22

3 participants