Skip to content

fix: Returned error for 5xx server response has incorrect format #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

fix: Returned error for 5xx server response has incorrect format #2755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/RESTController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ const RESTController = {
promise.reject('Unable to connect to the Parse API');
} else {
// After the retry limit is reached, fail
promise.reject(response);
const error = await response.json();
promise.reject(error);
}
} else {
promise.reject(response);
Expand Down
31 changes: 25 additions & 6 deletions src/__tests__/RESTController-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,19 +84,21 @@ describe('RESTController', () => {
});

it('aborts after too many failures', async () => {
expect.assertions(1);
expect.assertions(3);
mockFetch([
{ status: 500 },
{ status: 500 },
{ status: 500 },
{ status: 500 },
{ status: 500 },
{ status: 500, response: { code: 1, error: 'Internal server error.' } },
{ status: 500, response: { code: 1, error: 'Internal server error.' } },
{ status: 500, response: { code: 1, error: 'Internal server error.' } },
{ status: 500, response: { code: 1, error: 'Internal server error.' } },
{ status: 500, response: { code: 1, error: 'Internal server error.' } },
{ status: 200, response: { success: true } },
]);
try {
await RESTController.ajax('POST', 'users', {});
} catch (fetchError) {
expect(fetchError).not.toBe(undefined);
expect(fetchError.code).toBe(1);
expect(fetchError.error).toBe('Internal server error.');
}
});

Expand Down Expand Up @@ -178,6 +180,23 @@ describe('RESTController', () => {
}
});

it('handles 5xx errors after retries', async () => {
expect.assertions(2);
mockFetch([
{ status: 500, response: { code: 1, error: 'Internal server error.' } },
{ status: 500, response: { code: 1, error: 'Internal server error.' } },
{ status: 500, response: { code: 1, error: 'Internal server error.' } },
{ status: 500, response: { code: 1, error: 'Internal server error.' } },
{ status: 500, response: { code: 1, error: 'Internal server error.' } },
]);
try {
await RESTController.request('GET', 'classes/MyObject', {}, {});
} catch (error) {
expect(error.code).toBe(1);
expect(error.message).toBe('Internal server error.');
}
});

it('handles X-Parse-Job-Status-Id header', async () => {
mockFetch([{ status: 200, response: { results: [] } }], headers);
const response = await RESTController.request(
Expand Down