Skip to content

Conversation

@nlutsenko
Copy link
Contributor

If used with Cocoapods and minimum deployment target is set to iOS 9 - these two places were providing warnings.

  • Added compile time check for PFAlertView
  • Made PFPushUtilities use PFAlertView

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either wrap this in a #if TARGET_IOS_IPHONE check, or change PFAlertView's headers to support OS X.

I don't have a strong preference to either, though I think that long term making PFAlertView cross-platform (with a compile-time warning using NS_AVAILABLE and friends, if you attempt to actually call it on OS X) makes it much simpler to maintain long-term.

nlutsenko added a commit that referenced this pull request Aug 31, 2015
Fixed iOS 9 deprecation warnings in PFAlertView, PFPushUtilities.
@nlutsenko nlutsenko merged commit 9c8b6fd into master Aug 31, 2015
@nlutsenko nlutsenko deleted the nlutsenko.alerts branch August 31, 2015 21:41
@code-K
Copy link

code-K commented Dec 11, 2015

@nlutsenko with this one i'm getting now an issue... i updated to 1.10.0 through pods...
My target is set to iOS 8

getting now the following..

..../Pods/Parse/Parse/Internal/PFAlertView.h:22:1: 'showAlertWithTitle:message:cancelButtonTitle:otherButtonTitles:completion:' has been explicitly marked unavailable here

..../Pods/Parse/Parse/Internal/Push/Utilites/PFPushUtilities.m:63:18: 'showAlertWithTitle:message:cancelButtonTitle:otherButtonTitles:completion:' is unavailable: not available on iOS (App Extension)

have an extension for today widget.

Thanks much for feedback and best regards,
Christian

@nlutsenko
Copy link
Contributor Author

@code-K, the issue is fixed in #642 and will be included in the new release of the SDK.
You can get it faster - by referncing master of the repo in your Podfile.

@code-K
Copy link

code-K commented Dec 13, 2015

@nlutsenko Thanks much for the feedback! Works fine with master! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants