Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Oct 13, 2025

New Pull Request Checklist

Issue Description

The server expects excludeKeys to be passed instead of excludedKeys

Added in Parse-Server 3.6.0 parse-community/parse-server#5737

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the request parameter for excluding fields in query results, ensuring the server properly recognizes excluded fields.
    • Improves compatibility with the API by using the correct parameter name.
    • No other behavior or logic changed; existing queries should continue to work, with field exclusion now functioning as expected.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 13, 2025

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Oct 13, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link

coderabbitai bot commented Oct 13, 2025

📝 Walkthrough

Walkthrough

In PFRESTQueryCommand.m, the method findCommandParametersWithOrder:conditions:selectedKeys:includedKeys:excludedKeys:limit:skip:explain:hint:extraOptions:tracingEnabled:error: changes the parameter key used in the request payload from "excludedKeys" to "excludeKeys". No other logic or control flow is modified.

Changes

Cohort / File(s) Summary
Query parameter key rename
`Parse/Parse/Internal/Commands/PFRESTQueryCommand.m`
Replaced request parameter key "excludedKeys" with "excludeKeys" within findCommandParametersWithOrder:conditions:selectedKeys:includedKeys:excludedKeys:limit:skip:explain:hint:extraOptions:tracingEnabled:error:.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description includes the checklist and issue context but is missing required sections from the repository template, such as the Approach section, TODOs before merging, and a filled‐out issue closing reference, leaving the template incomplete. Update the description to fill in the Approach section, add a Closes reference for the related issue, complete any TODOs before merging, and mark checklist items appropriately to match the repository’s pull request template.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title check ✅ Passed The title accurately describes the main change: fixing an invalid query parameter name from 'excludedKeys' to 'excludeKeys' for excluding fields in query results.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 13, 2025
This reverts commit 078974e.

fix: Invalid parameter `excludedKeys`

fix build 1
coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 13, 2025
@dplewis dplewis requested review from a team and mtrezza November 17, 2025 18:44
@mtrezza mtrezza changed the title fix: Invalid parameter excludedKeys fix: Invalid request parameter excludedKeys for excluding fields in query results Nov 17, 2025
@mtrezza mtrezza changed the title fix: Invalid request parameter excludedKeys for excluding fields in query results fix: Invalid query request parameter excludedKeys for excluding fields in query results Nov 17, 2025
@mtrezza mtrezza changed the title fix: Invalid query request parameter excludedKeys for excluding fields in query results fix: Invalid query request parameter excludedKeys sent to server for excluding fields in query results Nov 17, 2025
@mtrezza mtrezza merged commit e14c4c5 into parse-community:master Nov 17, 2025
9 of 10 checks passed
parseplatformorg pushed a commit that referenced this pull request Nov 17, 2025
## [6.0.1](6.0.0...6.0.1) (2025-11-17)

### Bug Fixes

* Invalid query request parameter `excludedKeys` sent to server for excluding fields in query results ([#1864](#1864)) ([e14c4c5](e14c4c5))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants