Cleaned up usages of exceptions and asserts. #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
Should this be a .count like the others? I wasn't sure as it seemed suspect.
Contributor
There was a problem hiding this comment.
Should be checking for nil, since empty array there would mean that we should not fetch any keys explicitly.
richardjrossiii
force-pushed
the
richardross.assertions
branch
from
3d7e199 to
6d28cba
Compare
Contributor
Author
|
@nlutsenko diff updated. |
Contributor
There was a problem hiding this comment.
The comment sounds different, intentional?
Contributor
Author
There was a problem hiding this comment.
Copy-pasta spaghetti
Contributor
|
LGTM, minus nits. Please resolve all of them before merging. |
We no longer do `@throw [NSException exceptionWith...]` anywhere in the code base, replaced usages of `if (conditon) [NSException raise:...` with PFParamter/ConsistencyAssert where appropriate. This is related to #6.
richardjrossiii
force-pushed
the
richardross.assertions
branch
from
6d28cba to
a4c621c
Compare
richardjrossiii
added a commit
that referenced
this pull request
Aug 25, 2015
Cleaned up usages of exceptions and asserts.
richardjrossiii
added a commit
that referenced
this pull request
Aug 25, 2015
richardjrossiii
added a commit
that referenced
this pull request
Aug 26, 2015
Fixed assertion messages that were unintentionally changed in #86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer do
@throw [NSException exceptionWith...]anywhere in the code base, replaced usages ofif (conditon) [NSException raise:...with PFParamter/ConsistencyAssert where appropriate.This is related to #6.