This repository was archived by the owner on Jan 16, 2021. It is now read-only.
Add setup instructions to Contributing #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONTRIBUTING.md
Outdated
Contributor
There was a problem hiding this comment.
git submodule update --init --recursive to make sure that we have all the pieces and if we add any submodules later.
Contributor
There was a problem hiding this comment.
Also, technically - it's updating submodules, so can we replace update with Fetch required submodules
Contributor
|
Sorry, I am nitpicking here - it looks good, these are just suggestions on the language/details. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
and removed
GH Review: needs-revision
labels
Contributor
Author
|
Don't apologize! I agree with all of your edits, not as experienced as you with writing good documentation |
Contributor
|
Perfect! Thanks for making the changes. |
Language clarifications for Contributing setup
Contributor
Author
|
squashed |
Contributor
|
Whee! Awesome, merging! |
nlutsenko
added a commit
that referenced
this pull request
Jan 19, 2016
Add setup instructions to Contributing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.