This repository was archived by the owner on Jun 13, 2023. It is now read-only.
Properly deliver events back to objective-c #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was bugged, as HandlerConverter would be destroyed as soon as its scope was exited, causing no events to be delivered. By adding an associated object on the subscription that should be held onto by objective-c, it now only gets destroyed when the subscription does. Fixes #7.
|
|
||
| private let handler: ObjCCompat_SubscriptionHandling | ||
| private static var associatedObjectKey: Int = 0 | ||
| private weak var handler: ObjCCompat_SubscriptionHandling? |
Contributor
There was a problem hiding this comment.
Do we expect this ever to become nil? Not sure on why optional.
Contributor
Author
There was a problem hiding this comment.
Weak vars must be optional in swift. Compile error if not.
Contributor
There was a problem hiding this comment.
Aha, I completely missed the fact that it's weak now.
Contributor
|
Passing back for question. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was bugged, as HandlerConverter would be destroyed as soon as its scope was exited, causing no events to be delivered. By adding an associated object on the subscription that should be held onto by objective-c, it now only gets destroyed when the subscription does.
Fixes #7.