Skip to content

Update Parse to use public maven #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2015
Merged

Update Parse to use public maven #57

merged 1 commit into from
Aug 21, 2015

Conversation

@wangmengyan95
Copy link
Contributor

@wangmengyan95 wangmengyan95 commented Aug 14, 2015

No description provided.

grantland
grantland reviewed Aug 14, 2015
View reviewed changes
ParseLoginUI/build.gradle Outdated
Copy link
Contributor

@grantland grantland Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't need this anymore since we have a hard dependency on it already.

Copy link
Contributor

@grantland grantland Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops turns out we use provided for parse-android

@stanleyw: Know why we're doing this? ParseLoginUI is pretty useless without parse-android

Copy link
Contributor

@stanleyw stanleyw Aug 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Parse SDK was not in Maven before. We had to do this because people usually already have a Parse SDK JAR (of possibly different version) in their top-level project. If another Parse SDK JAR was also in ParseUI-Android folder, they would get confused when they copy the library folder into their app and get the "multiple dex files" error.

Anyways, the previous use case is no longer applicable now that we have Parse SDK in Maven :) So please ignore the previous setup.

@wangmengyan95 wangmengyan95 mentioned this pull request Aug 14, 2015
Closed
@grantland grantland assigned wangmengyan95 and unassigned grantland Aug 14, 2015
@grantland
Copy link
Contributor

grantland commented Aug 14, 2015

Some nits, LGTM

@grantland grantland assigned stanleyw and unassigned wangmengyan95 Aug 14, 2015
@hallucinogen
Copy link

hallucinogen commented Aug 15, 2015

🙌

@stanleyw stanleyw assigned wangmengyan95 and unassigned stanleyw Aug 15, 2015
@wangmengyan95 wangmengyan95 mentioned this pull request Aug 19, 2015
Merged
@wangmengyan95 wangmengyan95 mentioned this pull request Aug 19, 2015
Closed
@grantland
Copy link
Contributor

grantland commented Aug 19, 2015

LGTM

@grantland grantland assigned wangmengyan95 and unassigned grantland Aug 19, 2015
@grantland
Copy link
Contributor

grantland commented Aug 19, 2015

squash, merge, and rebase your other PR?

@wangmengyan95 wangmengyan95 force-pushed the wangmengyan.update_Parse_to_use_maven_public branch from 22326a0 to e84e398 Compare August 21, 2015 00:45
wangmengyan95 added a commit that referenced this pull request Aug 21, 2015
@wangmengyan95
Merge pull request #57 from ParsePlatform/wangmengyan.update_Parse_to…
76886c0 
…_use_maven_public

Update Parse to use public maven
@wangmengyan95 wangmengyan95 merged commit 76886c0 into master Aug 21, 2015
@wangmengyan95 wangmengyan95 deleted the wangmengyan.update_Parse_to_use_maven_public branch August 21, 2015 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wangmengyan95 wangmengyan95

Labels

accepted CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wangmengyan95 @grantland @hallucinogen @stanleyw @facebook-github-bot