Skip to content

fix: Currently displayed view reloads when editing and saving a different view #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2025
Merged

fix: Currently displayed view reloads when editing and saving a different view #3002

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2a3cbc
fix
mtrezza Oct 14, 2025
a4c1bb8
Merge branch 'alpha' into fix/view-reload
mtrezza Oct 14, 2025
3365cbb
fix
mtrezza Oct 14, 2025
d38a4bf
Merge branch 'fix/view-reload' of https://github.com/mtrezza/parse-da…
mtrezza Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/dashboard/Data/Views/Views.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class Views extends TableView {
}
}

async loadViews(app) {
async loadViews(app, skipDataReload = false) {
// Initialize ViewPreferencesManager if not already done or if app changed
if (!this.viewPreferencesManager || this.viewPreferencesManager.app !== app) {
this.viewPreferencesManager = new ViewPreferencesManager(app);
Expand Down Expand Up @@ -132,7 +132,7 @@ class Views extends TableView {
}
}
});
if (this._isMounted) {
if (this._isMounted && !skipDataReload) {
this.loadData(this.props.params.name);
}
});
Expand All @@ -141,7 +141,7 @@ class Views extends TableView {
// Fallback to local storage
const views = ViewPreferences.getViews(app.applicationId);
this.setState({ views, counts: {} }, () => {
if (this._isMounted) {
if (this._isMounted && !skipDataReload) {
this.loadData(this.props.params.name);
}
});
Expand Down Expand Up @@ -757,6 +757,9 @@ class Views extends TableView {
view={this.state.editView}
onCancel={() => this.setState({ editView: null, editIndex: null })}
onConfirm={view => {
// Use the original view name (before editing) to check if it's the currently displayed view
const originalViewName = this.state.editView?.name;
const isEditingCurrentView = originalViewName === this.props.params.name;
this.setState(
state => {
const newViews = [...state.views];
Expand All @@ -772,7 +775,10 @@ class Views extends TableView {
this.showNote('Failed to save view changes', true);
}
}
this.loadViews(this.context);
// Only reload data if we're editing the currently displayed view
// Otherwise just reload the view list without reloading data
const skipDataReload = !isEditingCurrentView;
this.loadViews(this.context, skipDataReload);
}
);
}}
Expand Down
Loading