Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Oct 25, 2025

New Pull Request Checklist

Issue Description

Upgrade of Parse JS SDK in #3003 increases required minimum version to Parse Server 7. The PR wasn't merged as breaking change, as planned in #2749.

This adds a feature to specify the compatible Parse Server versions in package.json. If a server is unsupported, a warning message is shown:

image

Approach

Add server compat table.

Summary by CodeRabbit

  • Documentation
    • Revised Parse Dashboard/Parse Server compatibility wording and restructured the compatibility table; added note about automatic server-version checks and minimum required version.
  • New Features
    • Dashboard now detects Parse Server version on connect and shows an in-app compatibility warning when requirements aren’t met.
  • Style
    • Updated app list layout and styling to surface metrics and version-warning notices.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 25, 2025

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

@coderabbitai
Copy link

coderabbitai bot commented Oct 25, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Added a Parse Server version compatibility check (driven by package.json) that attaches warnings to app serverInfo; updated UI to surface version warnings in app cards; reworked README compatibility table and added the supportedParseServerVersion field to package.json; related styling/layout adjusted.

Changes

Cohort / File(s) Change Summary
Documentation
README.md
Reworded Parse Server compatibility header, replaced a 3-column table with a 2-column table mapping Parse Dashboard to Parse Server versions, and added a paragraph describing automatic server-version checks and the package.json supportedParseServerVersion field.
Manifest
package.json
Added top-level field supportedParseServerVersion: "=>>7.0.0" (declares the minimum supported Parse Server version).
UI — App list
src/dashboard/Apps/AppsIndex.react.js, src/dashboard/Apps/AppsIndex.scss
Restructured AppCard markup by introducing .appCardContent wrapper, moved metrics into an inline "At a glance" area, added conditional rendering for a .versionWarning element, and updated styles (flex layout changes, .versionWarning orange styling, min-height adjustments).
Runtime — Dashboard logic
src/dashboard/Dashboard.js
Imported semver and package.json info; after fetching app serverInfo, coerce/validate server version against supportedParseServerVersion; if incompatible, attach app.serverInfo.versionWarning with guidance text.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant UI as Dashboard UI
  participant AppSvc as App Loader
  participant Server as Parse Server
  participant Semver as semver + package.json

  UI->>AppSvc: load apps list
  AppSvc->>Server: fetch serverInfo for each app
  Server-->>AppSvc: serverInfo (includes parseServerVersion)
  AppSvc->>Semver: read supportedParseServerVersion & validate(serverVersion)
  alt version satisfies range
    Semver-->>AppSvc: ok
    AppSvc-->>UI: attach serverInfo (no warning)
  else version does NOT satisfy
    Semver-->>AppSvc: incompatible
    AppSvc-->>UI: attach serverInfo with versionWarning
    UI-->>UI: render .versionWarning in AppCard
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Potential attention points:

  • Version-parsing edge cases in Dashboard.js (coerce/clean behavior, handling 'unknown', pre-release tags).
  • String content and i18n/formatting of the versionWarning message.
  • Visual/layout impact of .appCardContent and .versionWarning across breakpoints and existing styles.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title Check ⚠️ Warning The pull request title states "feat: Add Parse Server version compatibility detection," which suggests a new feature involving version detection functionality. However, the actual changes are purely documentation updates to the README file: rewording a compatibility description and reformatting a compatibility table with updated version mappings. The term "detection" implies code-level version detection logic, which is not present in the changeset. While the title does reference Parse Server version compatibility (which is the topic of the PR), the use of "feat:" prefix and the specific term "detection" misrepresent the nature of the changes as documentation-only updates. Consider revising the title to accurately reflect the documentation updates, such as "docs: Update Parse Server version compatibility table" or "docs: Clarify Parse Server version compatibility requirements." This would set proper expectations about the scope of the PR being documentation-focused rather than featuring new detection functionality.
Description Check ❓ Inconclusive The PR description follows most of the template structure with the checklist items properly completed and sections for Issue Description and Approach present. However, the description has notable gaps: the entire "TODOs before merging" section is missing, the Issue Description lacks the suggested "Closes: ISSUE_NUMBER" format to reference a specific issue, and the Approach section is extremely minimal, consisting only of "Add server compat table" without detail about implementation. While the core content explains what the PR addresses and the general approach taken, the brevity and missing structural elements prevent a clear assessment of completeness against the template requirements.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f58d584 and 301676b.

📒 Files selected for processing (5)
  • README.md (1 hunks)
  • package.json (1 hunks)
  • src/dashboard/Apps/AppsIndex.react.js (1 hunks)
  • src/dashboard/Apps/AppsIndex.scss (2 hunks)
  • src/dashboard/Dashboard.js (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Oct 25, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 25, 2025
@mtrezza
Copy link
Member Author

mtrezza commented Oct 25, 2025

BREAKING CHANGE: This increases the required version to Parse Server 7.

@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Oct 25, 2025

Uffizzi Ephemeral Environment deployment-65692

⌚ Updated Oct 25, 2025, 01:22 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/3004

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza changed the title fix: Missing parse server version compatibility feat: Add Parse Server version compatibility detection Oct 25, 2025
@mtrezza mtrezza merged commit 9a7a60f into parse-community:alpha Oct 25, 2025
10 of 11 checks passed
parseplatformorg pushed a commit that referenced this pull request Oct 25, 2025
# [7.6.0-alpha.13](7.6.0-alpha.12...7.6.0-alpha.13) (2025-10-25)

### Features

* Add Parse Server version compatibility detection ([#3004](#3004)) ([9a7a60f](9a7a60f))
@mtrezza mtrezza deleted the fix/missing-parse-server-version-compat branch October 25, 2025 01:54
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.6.0-alpha.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants