Delete subscription on SIGTERM / SIGINT #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appaquet
approved these changes
Apr 17, 2017
Collaborator
appaquet
left a comment
appaquet
left a comment
There was a problem hiding this comment.
Looks good after small comment
lib/index.js
Outdated
|
|
||
| function deleteSubscription() { | ||
| removeListeners(); | ||
| console.log('Subscriber: SIGTERM received, deleting subscription'); |
Collaborator
There was a problem hiding this comment.
Nits, but SIGTERM is misleading here since it's also called on SIGINT. You could just say "signal received"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to create 1 subscription per server for the fan-out to work correctly, this involves deleting those subscriptions when killing the server.
Also, the module now will re-create the sub when the subscription is deleted remotely too.