Handle immutable configuration#33
Merged
flovilmart merged 2 commits intoparse-community:masterfrom Dec 6, 2016
Merged
Conversation
The popular and awesome https://github.com/lorenwest/node-config makes all configs values immutable. Good practice! parse-server-s3-adapter attempts to edit config values. This fix will respect immutability allowing this adapter to work with node-config.
Current coverage is 69.53% (diff: 100%)@@ master #33 diff @@
==========================================
Files 2 2
Lines 127 128 +1
Methods 9 9
Messages 0 0
Branches 25 25
==========================================
- Hits 121 89 -32
- Misses 6 39 +33
Partials 0 0
|
flovilmart
suggested changes
Dec 6, 2016
| @@ -0,0 +1 @@ | |||
| process.env.NODE_ENV = 'test'; | |||
Contributor
There was a problem hiding this comment.
I don't like those env overrides in code, can we put it in the test command?
| describe('S3Adapter tests', () => { | ||
| beforeEach(() => { | ||
| delete process.env.S3_BUCKET; | ||
| delete process.env.S3_REGION |
1. move setting NODE_ENV to test command instead of helpers. 2. add a missing ;. lint coming.....
flovilmart
approved these changes
Dec 6, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The popular and awesome https://github.com/lorenwest/node-config
makes all configs values immutable. Good practice!
parse-server-s3-adapter attempts to edit config values.
This fix will respect immutability allowing this adapter
to work with node-config.