Skip to content

Adds option to specify an alternate baseUrl (e.g. CloudFront)#6

Merged
drew-gross merged 2 commits intoparse-community:masterfrom
davidruisinger:master
Apr 22, 2016
Merged

Adds option to specify an alternate baseUrl (e.g. CloudFront)#6
drew-gross merged 2 commits intoparse-community:masterfrom
davidruisinger:master

Conversation

@davidruisinger
Copy link
Copy Markdown
Contributor

The option is optionally, based on the requirement from parse-community/parse-server#792

@codecov-io
Copy link
Copy Markdown

Current coverage is 60.22%

Merging #6 into master will decrease coverage by -34.96% as of a1eca44

@@            master      #6   diff @@
======================================
  Files            1       1       
  Stmts           83      88     +5
  Branches        14      15     +1
  Methods          0       0       
======================================
- Hit             79      53    -26
  Partial          0       0       
- Missed           4      35    +31

Review entire Coverage Diff as of a1eca44

Powered by Codecov. Updated on successful CI builds.

@drew-gross
Copy link
Copy Markdown

@skinp can you take a look at this? It seems to make sense to me but I don't have much experience with this kind of thing.

Comment thread README.md Outdated
"directAccess": false // default value
}
"directAccess": false, // default value
"baseUrl": null // default value
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit indent

@skinp
Copy link
Copy Markdown

skinp commented Apr 22, 2016

@drew-gross yes it makes sense to me too and looks good on the S3 side. Was planning on adding exactly this at some point so +1 to @flavordaaave for doing that.

I'm not sure why code coverage dropped though, maybe we want to look into it...

@drew-gross
Copy link
Copy Markdown

Covecov seems to actually just be a random number generator sometimes. I will merge when the indentations issues are sorted out.

@davidruisinger
Copy link
Copy Markdown
Contributor Author

@drew-gross indentions have been fixed.

@flovilmart
Copy link
Copy Markdown
Contributor

flovilmart commented Apr 22, 2016

@skinp seems that the S3 env variables are not properly exported with that test.

@drew-gross drew-gross merged commit 4b628f1 into parse-community:master Apr 22, 2016
@davidruisinger
Copy link
Copy Markdown
Contributor Author

@drew-gross will this pull request be automatically available in the npm repository or is there anything I can do to assist?

@drew-gross
Copy link
Copy Markdown

@flovilmart has been handling releases for this repo. Can you do a release?

@flovilmart
Copy link
Copy Markdown
Contributor

I'll Just need to push a new tag

@flovilmart
Copy link
Copy Markdown
Contributor

flovilmart commented Apr 26, 2016

sorry for the late response. it's distributed as 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants