This repository was archived by the owner on May 13, 2025. It is now read-only.
feat: add feature to reorder columns #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #59 |
Ryiski
reviewed
Jul 30, 2023
kartik-gupta-ij
approved these changes
Jul 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with changing streams and reordering columns multiple times.
Some concerns:
react-beautiful-dndlibrary adds some load time but it is one of the more stable dnd frameworks, I am open to any suggestions for any other libraries.Some libraries I know about:
@dnd-kit: Somewhat smallerreact-dnd: Slightly smaller than@dnd-kitreact-grid-layout: Size betweenreact-beautiful-dndand@dnd-kit, but can be considered if the project is expected to have resizable and/or movable widgets since it can also manage thatLet me know what you think