Delete/ingestor #266
Delete/ingestor #266
Conversation
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
You shouldn't use 'as' like this which is falsy. Fix the ts errors. Straight forward.
There was a problem hiding this comment.
Please configure your formatting settings and let's make sure we don't commit unwanted changes.
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
Use proper naming conventions.
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
height prop doesnt allow css units it takes only number as input
There was a problem hiding this comment.
use size like everywhere else.
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
Use flex. Why the fixed width percentage ?
src/pages/Systems/MachineInfo.tsx
Outdated
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
Use proper variable names
|
I am still seeing the indentation changes. |
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
Still not using the correct case.
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
why openDeleteModal as a dependency here ?
I would suggest that you go through the useCallback documentation.
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
How about toggleModal that handles both opening and closing modal.
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
use more appropriate variable name and why are you getting the URL from recentRecord ?
Try to take the address from the store.
There was a problem hiding this comment.
recentRecord is already returning the currentMachineRecentRecord.
There was a problem hiding this comment.
Use more appropriate name
There was a problem hiding this comment.
I don't think the indentation spaces used here are correct.
Please follow the existing configuration.
There was a problem hiding this comment.
marginLeft value is not a correct string.
There was a problem hiding this comment.
Get this from the store from currentMachine.domain_name
There was a problem hiding this comment.
name should be onDeleteIngestorSuccess
There was a problem hiding this comment.
empty line after exit condition.
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
appropriate variable name here.
openDeleteModal sounds like a function here.
There was a problem hiding this comment.
why the dependency here ?
There was a problem hiding this comment.
Still the value is not correct.
Koustavd18
dismissed stale reviews from nikhilsinhaparseable and balaji-jr
via
66c27b8
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
This doesn't fix the issue ie: showing empty data on machine info.
-Fixed : Delete button was visible even when the ingestor was online -Added: Skeleton Loader to Instance Info
removed unecessary call for ingestor query
Now if a ingestor is offline a delete icon will appear in the cluster page which will allow the user to delete the offline ingestor
4 participants
No description provided.