Table/copy btn #268
Table/copy btn #268
Conversation
There was a problem hiding this comment.
lets keep using existing color codes ie using hex or color names or mantine theme variables.
There was a problem hiding this comment.
new line after exit condition
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
proper variable name here
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
Changed implementation
There was a problem hiding this comment.
The copy btn should be in absolute position.
|
Mantine's copy action with render fn will slow down the explore table. |
src/pages/Systems/MachineInfo.tsx
Outdated
There was a problem hiding this comment.
This works. But lets keep the type as boolean;
There was a problem hiding this comment.
why the fieldvalue is any ?
There was a problem hiding this comment.
the name doesn't feel like its a react component.
There was a problem hiding this comment.
parseLogData has a return type of any., which is then passed to this function
There was a problem hiding this comment.
if you are clearing the state on mouse leave, why are you sending 0,0 as params if it only depends on the third argument?
Update the params of handleMouseHover.
There was a problem hiding this comment.
This is still not correct.
What if I send (true) as arg ?
There was a problem hiding this comment.
updated but please verify
There was a problem hiding this comment.
Instead of making args optional, create two separate functions for setHoveredCell(null) & setHoveredCell(index).
There was a problem hiding this comment.
Instead of making args optional, create two separate functions for setHoveredCell(null) & setHoveredCell(index).
4 participants
Changes.
On timestamp modal the color of the X(cross) button changed to white.
On selecting text from the table the timestamp modal is prevented from opening