Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Conversation

@Koustavd18
Copy link
Contributor

Fix: This PR changes the JSON view to show the keys with a valid value

@Koustavd18 Koustavd18 requested a review from balaji-jr August 21, 2024 09:23
Copy link
Contributor

@balaji-jr balaji-jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To find the valid headers you are iterating the log object twice which is unnecessary.
log[header] === null ? 'null': And not clear why this is needed and why its included in the finding valid headers logic ?

@Koustavd18 Koustavd18 requested a review from balaji-jr August 22, 2024 09:18
@Koustavd18 Koustavd18 requested a review from balaji-jr August 22, 2024 12:49
@Koustavd18 Koustavd18 requested a review from balaji-jr August 23, 2024 06:17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is still needed.
If you are iterating over a log object, why you'd want to test whether its empty or not ?

@balaji-jr
Copy link
Contributor

I will address the remaining changes on #303

balaji-jr
balaji-jr previously approved these changes Aug 23, 2024
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nikhilsinhaparseable nikhilsinhaparseable merged commit 26b6494 into parseablehq:main Aug 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
@Koustavd18 Koustavd18 deleted the JSON/validCols branch August 28, 2024 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants