-
-
Couldn't load subscription status.
- Fork 36
Json/valid cols #299
Json/valid cols #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To find the valid headers you are iterating the log object twice which is unnecessary.
log[header] === null ? 'null': And not clear why this is needed and why its included in the finding valid headers logic ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this is still needed.
If you are iterating over a log object, why you'd want to test whether its empty or not ?
|
I will address the remaining changes on #303 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Fix: This PR changes the JSON view to show the keys with a valid value