This repository was archived by the owner on May 13, 2025. It is now read-only.
Fix: Create User action #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balaji-jr
suggested changes
Sep 2, 2024
|
#309 (comment) |
balaji-jr
previously approved these changes
Sep 3, 2024
|
Adding changes to the create role actions in this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current create user modal allows to create user without any role specified.
The create role action also allows to create a role without a privilege.
Changes
This PR makes sure that the create button is disabled unless the role is selected by the user
For create role this pr makes sure both role name and privilege is set before allowing the user to create a role