fix: update version in vectoradd_jax example to not result in invalid docker tag #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmheiko
requested review from
apaleyes,
dionhaefner and
xalelax
as code owners
Contributor
|
thanks @zmheiko ! have you tested this, e.g. by running the failing notebook? |
Contributor
Author
|
Yes, the demo notebook still runs through. I tested that locally and should have mentioned that in the PR. I could not run the actual tests locally because of a weird docker issue I'm having (unrelated to the actual issue here), so I had to fall back to the GitHub runner to do the testing for me :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updated version in
vectoradd_jaxexample to not result in invalid docker tag